Can't insert data into mysql with php

Question

ok so I can connect and view the database with my php code, however I can not insert data into it.here is the query I tested with phpmyadmin which was able insert new data into my table

INSERT INTO `members` ( `id` , `username` , `email` ) 
VALUES ( 123456789, 'russi', 'baka@dog.com' )

then I tried to put it into my actual php file

<?php
$servername = "localhost";
$username = "root";
$password = "blablabla";
$dbname = "test_database";

// Create connection
$conn = new mysqli($servername, $username, $password, $dbname);
// Check connection
if ($conn->connect_error) {
    die("Connection failed: " . $conn->connect_error);
}
$sql = "INSERT INTO 'members' ('id', 'username', 'email')
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";
$sql = "SELECT id, username, email FROM members";
$result = $conn->query($sql);

if ($result->num_rows > 0) {
    // output data of each row
    while($row = $result->fetch_assoc()) {
        echo "id: " . $row["id"]. " - username: " . $row["username"]. " -email:" . $row["email"]. "<br>";
    }
} else {
    echo "0 results";
}
$conn->close();
?>

so select function works but insert does not.

Your INSERT query is immediately overwritten by a SELECT query and never executed. — , May 02 '15 at 21:14

score 2 · Accepted Answer · edited May 23 '17 at 11:43

2

You are overriding your $sql variable w/o executing it. Besides that you should not use single quotes for columns, but backticks (see When to use single quotes, double quotes, and backticks in MySQL)

Change

$sql = "INSERT INTO 'members' ('id', 'username', 'email')
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";
$sql = "SELECT id, username, email FROM members";
$result = $conn->query($sql);

to

$sql = "INSERT INTO `members` (`id`, `username`, `email`)
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";
$result = $conn->query($sql);
$sql = "SELECT id, username, email FROM members";
$result = $conn->query($sql);

edited May 23 '17 at 11:43

Community

1
1

answered May 02 '15 at 21:13

MrTux

32,350
30
109
146

for some reason still wont work so i will have to check with my prof whats going on there – alkokarko May 02 '15 at 21:32
fixed the problem, i had some items in the tale that did not have default values. – alkokarko May 02 '15 at 22:33

Adrian Cid Almaguer · Answer 2 · 2015-05-02T21:18:14.070

1

Change your insert to:

$sql = "INSERT INTO members (id, username, email)
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";

And call your query:

$sql = "INSERT INTO members (id, username, email)
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";
//Here, you never execute your query
$result = $conn->query($sql);

$sql = "SELECT id, username, email FROM members";
$result = $conn->query($sql);

edited May 02 '15 at 21:18

answered May 02 '15 at 21:13

Adrian Cid Almaguer

7,815
13
41
63

@Jens Sure was somebody that loves the Down Vote Button ;-) – Adrian Cid Almaguer May 02 '15 at 21:17

score 1 · Answer 3 · answered May 02 '15 at 21:22

1

Of course it did not work !

You never execute your INSERT...

<?php
...
$sql = "INSERT INTO 'members' ('id', 'username', 'email')
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";
$conn->exec($sql);
$sql = "SELECT id, username, email FROM members";
$result = $conn->query($sql);
...

:)

answered May 02 '15 at 21:22

roillion

23
5

There is no `exec` method, is there? (https://php.net/manual/de/class.mysqli.php) also the single quotes are wrong. – MrTux May 02 '15 at 21:23

score 0 · Answer 4 · answered May 02 '15 at 21:13

remove the single quotes around your column and table names:

$sql = "INSERT INTO members (id, username, email)
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";

single quotes are only used for char fields.

Also you never execute the insert Statement because you overwrite it.

score 0 · Answer 5 · answered May 02 '15 at 21:35

$sql = "INSERT INTO 'members' ('id', 'username', 'email')
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";
$sql = "SELECT id, username, email FROM members";
//missing the grave accent 
$sql = "INSERT INTO `members` (id, username, email)
VALUES (2339978, 'vladtheimpalor', 'vladtheimaplor@bloody.com')";  

$sql = "SELECT `id`, `username`, `email` FROM `members`";

/* This is the corrrected code */

Can't insert data into mysql with php

5 Answers5