3

I'm new to Reactjs and making a directory browsing application with Cordova and Reactjs.

Currently I get the error this.props.onClick is not a function, I figured out that this.props.onClick is undefined. Check my code below:

var RepositoryList = React.createClass({
    //updating the list from a child folder entry
    updateListFromChild:function(childFolder){ 
        console.log("in parent update");
    },    
    render:function(){
        console.log(this.updateListFromChild); //function()
        var itemsInRepo = this.props.items.map(function(entry){
            console.log("in map: " + this.updateListFromChild); //undefined
            return (
                <RepositoryEntry repositoryItem={entry} 
                                 folderOnClick={this.updateListFromChild} />
            );
        });
        return (
            <ul className="table-view">
                {itemsInRepo}
            </ul>
        );
    }
});

The property folderOnClick is undefined. But I don't know how to solve this problem. Can someone point this out?

php-dev
  • 6,998
  • 4
  • 24
  • 38
user2810895
  • 1,284
  • 3
  • 19
  • 33

2 Answers2

6

In general - this is the "dynamic this" issue in JavaScript.

However, since you're using ReactJS with JSX, your code has support for ES6 arrow functions in the transform anyway:

var itemsInRepo = this.props.items.map(entry => (                
   <RepositoryEntry repositoryItem={entry} folderOnClick={this.updateListFromChild} />
));

You can see the syntax on MDN for more examples.

Community
  • 1
  • 1
Benjamin Gruenbaum
  • 270,886
  • 87
  • 504
  • 504
0

We can proceed with this way also. Here is the code snippet:

var itemsInRepo = this.props.items.map( 
        function(entry){                
            return(
             <RepositoryEntry 
               repositoryItem={entry} 
               folderOnClick={this.updateListFromChild} 
        />);
Paul Roub
  • 36,322
  • 27
  • 84
  • 93
Soma Sarkar
  • 836
  • 6
  • 7