How to print "correct" after user answers something correctly in python version 3.4.3

Question

This is my current code it prints two random numbers between 1 and 20 and asks the user to add them together. I want it to say correct when the answer has been answered correctly, but I am not to sure how to do this.

The program runs fine it will work but when the user enters the correct answer nothing happens.

from random import randint


def Add(x, y):

    return x + y


num1 = randint(1,20)
num2 = randint(1,20)
print(num1, "+", num2)
answer = input("What is the answer to the question: ")

if ("answer") is (num1 + num2):
    print("Correct")

Are you running python2.x or python 3.x? The input() function changed between these versions. — Robert Jacobs, May 07 '15 at 21:12

score 4 · Accepted Answer · edited May 23 '17 at 12:30

4

You need to cast input to an int, use the actual variable answer and don't use is to test equality, is should be used to check identity, and will fail for numbers > 256 in your case:

num1 = randint(1,20)
num2 = randint(1,20)
print(num1, "+", num2)
answer = int(input("What is the answer to the question: "))

if  answer ==  num1 + num2:
    print("Correct")

Why is should not be used:

In [35]: i = 256

In [36]: j = 256

In [37]:  i is j
Out[37]: True

In [38]: i = 257

In [39]: j = 257

In [40]:  i is j
Out[40]: False

The only reason i is j is True for 256 is because python caches small ints from -5 to 256.

edited May 23 '17 at 12:30

Community

1
1

answered May 07 '15 at 21:16

Padraic Cunningham

176,452
29
245
321

Thank you this cleared it up but do you know how I would go about making it say "Inncorrect" if the answer is wrong I can't seem to us an else. – elitereece May 07 '15 at 21:29
@elitereece,adding which? `num1 + num2` is adding the two random numbers – Padraic Cunningham May 07 '15 at 21:30
Yea I edited the comment. I'm new to this site pressed enter and it saved. – elitereece May 07 '15 at 21:31
I mean it says correct when you get the right answer but I'm not to sure how to make it say incorrect when you get the answer wrong. – elitereece May 07 '15 at 21:36
`else:print("You suck at math")` – Padraic Cunningham May 07 '15 at 21:39
if answer == (num1 + num2): print("Correct"), else:print("Incorrect") So it should fit in like this? – elitereece May 07 '15 at 21:43
yes but no comma and the else is at the same indentation as the if on the following line – Padraic Cunningham May 07 '15 at 21:44

score 2 · Answer 2 · answered May 07 '15 at 21:12

2

You put answer in quotations which means that the program is expecting the string "answer" instead of the variable.

answered May 07 '15 at 21:12

Gavin Hardison

21
4

Robert Jacobs · Answer 3 · 2015-05-07T21:39:36.277

0

I fixed your last line. I used your Add() function just because you defined it.

from random import randint


def Add(x, y):

    return x + y


num1 = randint(1,20)
num2 = randint(1,20)
print(num1, "+", num2)
answer = input("What is the answer to the question: ")

if int(answer) == Add(num1 , num2):
    print("Correct")
else:
    print("Incorrect")

edited May 07 '15 at 21:39

answered May 07 '15 at 21:19

Robert Jacobs

3,266
1
20
30

How to print "correct" after user answers something correctly in python version 3.4.3

3 Answers3