Trying to dismiss Progress Dialog

Question

I am using Async Task to perform some operations in my database. During the operation, I'm showing a progress dialog and when it operations are finish I want to dismiss it but it doesn't work.

private ProgressDialog progressDialog; 

private void showProgressDialog(String title, String message)
{
    progressDialog = new ProgressDialog(this);

    progressDialog.setTitle(title); //title

    progressDialog.setMessage(message); // message

    progressDialog.setCancelable(true);

    progressDialog.show();
}

private class InsertFoodAsyncTask extends AsyncTask<Void, Integer, String>{

    @Override
    protected String doInBackground(Void... arg0){
        InsertFood p = new InsertFood(Food.this,mBDD);
        p.InsertFood();

        return "Executed";
    }

    @Override
    protected void onPreExecute() {
        showProgressDialog("Please wait...", "Your message");
    }

    @Override
    protected void onPostExecute(String result) {
        if(progressDialog != null && progressDialog.isShowing())
        {
            progressDialog.dismiss();
        }
    }
}

Can you help me ? Thanks a lot !

Shouldn't progressDialog.dismiss() be called on the main UI thread? — SparkyRobinson, May 08 '15 at 22:26
@SparkyRobinson `onPostExecute()` does run on the main UI thread. — Daniel Nugent, May 08 '15 at 22:33
I just tested this code, and it worked just fine for me having `InsertFoodAsyncTask` as an inner class of the Activity. — Daniel Nugent, May 08 '15 at 22:49

score 1 · Answer 1 · edited Jan 02 '16 at 12:33

1

Try it,

replace:

progressDialog.show();

for:

progressDialog = progressDialog.show();

edited Jan 02 '16 at 12:33

rebatoma

734
1
17
32

answered Jan 02 '16 at 11:30

user5737937

11
1

score 0 · Answer 2 · answered May 09 '15 at 06:43

0

It seems all correct in your code. onPostExecute() already make it run on ui thread. But still try to check with this also.

getActivity().runOnUiThread(new Runnable() {
               @Override
               public void run() {
                    if(progressDialog != null && progressDialog.isShowing())
                    {
                        progressDialog.dismiss();
                    }
               }
            });

answered May 09 '15 at 06:43

Meenaxi

567
5
17

It works without modifications, I putted also the method calling the progress dialog in onResume, so it was launched two times...sorry for the loss of time ! – Kmel May 09 '15 at 20:34

Trying to dismiss Progress Dialog

2 Answers2