VB - Had a function working, doesn't anymore

Question

EDIT: Ok, it's because I'm using 2.0 Framework. Any ideas how I can modify that area or alternatives? I have to, unfortunately, stick with 2.0

Dim dir2 As New DirectoryInfo("d:\input")
    Dim sw2 As New StreamWriter("d:\input\reportCond.txt")
    For Each fi2 As FileInfo In dir2.GetFiles("report.txt")
        Dim sr2 As New StreamReader(fi2.FullName)
        While Not sr2.EndOfStream
            Dim sLine As String = sr2.ReadLine
            Dim myPath As String = sLine
            Dim fileName As String =System.IO.Path.GetFileNameWithoutExtension(myPath)
            Dim letters As String = fileName.Where(Function(c) Char.IsLetter(c)).ToArray
            Dim comp As String = sLine.Substring(28)
            sw2.WriteLine(letters)
        End While
    Next

The Code above was working fine yesterday, today it doesn't and I can't figure out why. The only difference was yesterday I ran it on VS2013, today it doesn't work on VS2010.

I get an error on Function saying "expression expected"

And another one on sw2.WriteLine(letters) saying "Name 'letters' is not declared.

Just to confirm: you are sure that d:\input\ contains one or more files named report.txt and those files contain some text and each line is at least 28 chars long. — tgolisch, May 13 '15 at 17:50
Also, to clarify, are you getting a run-time error or it won't even compile and run? — tgolisch, May 13 '15 at 17:50
@tgolisch, yes, file is in the location, and text is longer than 28 chars. but it won't run, getting the errors on the error list. — Gmac, May 13 '15 at 17:54
I got a feeling you were Option Explicit Off and now you have it On. — the_lotus, May 13 '15 at 18:04
... and which version of .Net are you targeting in each instance? — ChicagoMike, May 13 '15 at 18:08
@Gmac There is [no LINQ in .NET 2.0](http://stackoverflow.com/q/2138/11683), have to use v3.5+. — GSerg, May 13 '15 at 18:18

score 3 · Accepted Answer · answered May 13 '15 at 18:43

3

Here is how the linq Where part can be replaced to get the letters variable - which contains characters from the file name.

dim c as char
Dim letters As String 
for each c in s
    if char.IsLetter(c)
        letters += c
    end if
next

answered May 13 '15 at 18:43

shahkalpesh

33,172
3
63
88

Will for each work in 2.0? If not a regular for will do the job. – Fjodr May 13 '15 at 18:50
1

In VB .Net, you probably want to use `&=` instead of `+=` for string concatenation. `StringBuilder` class would be even better. – Douglas Barbin May 13 '15 at 18:52

score 1 · Answer 2 · answered May 13 '15 at 18:56

I would use the StringBuilder class to build the string:

    Dim dir2 As New DirectoryInfo("d:\input")
    Dim sw2 As New StreamWriter("d:\input\reportCond.txt")
    For Each fi2 As FileInfo In dir2.GetFiles("report.txt")
        Dim sr2 As New StreamReader(fi2.FullName)
        While Not sr2.EndOfStream
            Dim sLine As String = sr2.ReadLine
            Dim myPath As String = sLine
            Dim fileName As String =System.IO.Path.GetFileNameWithoutExtension(myPath)

            ' Build string
            Dim sb As New System.Text.StringBuilder()
            For Each c As Char In fileName
                If Char.IsLetter(c) Then
                    sb.Append(c)
                End If
            Next

            Dim comp As String = sLine.Substring(28)

            ' Here's the string you built
            Dim letters As String = sb.ToString()
            sw2.WriteLine(letters)
        End While
    Next

Josh Part · Answer 3 · 2015-05-13T20:41:04.773

1

A .Net 2.0 framework alternative to the Where extension method could be:

Dim letters As String = Array.FindAll(fileName.ToCharArray(), AddressOf Char.IsLetter)

This will create a new array of chars whose elementes will be all chars of fileName.ToCharArray for wich Char.IsLetter is True

edited May 13 '15 at 20:41

answered May 13 '15 at 20:26

Josh Part

2,154
12
15

VB - Had a function working, doesn't anymore

3 Answers3