JavaScript First Letter Capitalisation Not Working

Question

Firstly, this is my first time working with JavaScript so it is probably just me missing something very simple.

All I want to do is get the value of a text box and make an alert with the first letter capitalised. I have everything working, the first letter isn't actually being capitalised.

This is how I am calling the function:

else
{
    input = document.getElementById("search").value;
    'input'.search();
    alert(input);
}

This is the function it self:

function search(string)
{
    return string.charAt(0).toUpperCase();
}

You are calling your function on a text literal, and you are not doing anything with its return value. — CBroe, May 20 '15 at 11:59
possible duplicate of [Capitalize the first letter of string in JavaScript](http://stackoverflow.com/questions/1026069/capitalize-the-first-letter-of-string-in-javascript) — Anonymous, May 20 '15 at 11:59

score 2 · Accepted Answer · answered May 20 '15 at 11:58

2

this is the correct code

else
{
    input = document.getElementById("search").value;
    input =search(input);
    alert(input);
}

answered May 20 '15 at 11:58

user3227295

2,168
1
11
17

score 0 · Answer 2 · answered May 20 '15 at 11:58

0

Try this:

input = search(input);

Instead of:

'input'.search();

answered May 20 '15 at 11:58

StudioTime

22,603
38
120
207

score 0 · Answer 3 · answered May 20 '15 at 12:03

You aren't changing input at all. Try:

else
{
    input = document.getElementById("search").value;
    alert(search(input));
}

If you want to permanently change input Try:

else
{
    input = document.getElementById("search").value;
    input = search(input);
    alert(input);
}

score 0 · Answer 4 · answered May 20 '15 at 12:04

A couple of things wrong here,

firstly,

search(input)

instead of

'input'.search()

secondly,

string is immutable so you'll have to do,

input = search(input);
alert(input);
.
.
.
function search(str) {
    return (str.replace(str.charAt(0), str.charAt(0).toUpperCase()));
}

Newinjava · Answer 5 · 2015-05-20T12:09:35.887

0

Your question is not pretty clear to me, but I assume that you want, if your input string is "hello" , you want the output as "Hello".

Try this

call the method and alert the message:-

alert(search(input));

in the method:-

return Character.toUpperCase(input.charAt(0)) + input.substring(1);

edited May 20 '15 at 12:09

answered May 20 '15 at 12:04

Newinjava

972
1
12
19

Thank you very much, I didn't think about need the .substring so this saved me some time. :) – aarontbarratt May 20 '15 at 12:25

num8er · Answer 6 · 2015-05-20T12:13:15.603

0

String.prototype.capitalize = function() {
    return this.charAt(0).toUpperCase()+this.slice(1);
}

var searchField = document.getElementById("search");
var query = searchField.value;
searchField.value = query.capitalize();

function search(query) {
   // query api or something...
}

edited May 20 '15 at 12:13

answered May 20 '15 at 12:04

num8er

18,604
3
43
57

score -1 · Answer 7 · edited May 23 '17 at 12:05

-1

The answers are correct, but you will have only the first letter in the alert box. If you don't want only the first letter, here is the solution:

function search(string)
{
    return string.substring(0,1).toLocaleUpperCase() + string.substring(1);
}

From https://stackoverflow.com/a/30123193/2379208

edited May 23 '17 at 12:05

Community

1
1

answered May 20 '15 at 12:03

Kaymaz

454
8
23

It would be better to flag it as a duplicate than to take an answer from the question I linked and post it. – Anonymous May 20 '15 at 12:04

JavaScript First Letter Capitalisation Not Working

7 Answers7