Event doesn't work when element isn't loaded directly

Question

I have a table with many checkboxes which is generated with Ajax :

$.ajax({
    type: "GET",
    url: "jsonDevisUtilisateur.php?ra=" + $('#ra').val(),
    success: function(data) {
        var table = "<table class='dvs'><tr><td>Numéro</td><td>Client</td><td>Site</td><td>Libellé</td><td>Statut</td><td></td></tr>"
        for (var i = 0; i < data.length; i++) {
            table += "<tr><td>" + data[i].numDevis + "</td>";
            table += "<td>" + data[i].client + "</td>";
            table += "<td>" + data[i].site + "</td>";
            table += "<td>" + data[i].libelle + "</td>";
            table += "<td>" + data[i].statut + "</td>";
            table += "<td><input type='checkbox' class='box' value='" + data[i].id + "' name='box[]'></td></tr>"
        }
        table += "</table>";
        document.getElementById('devis').innerHTML = table + "<br/><br/>";
    }
});

This part is working well ! The problem is when I'm trying to integrate a "select all" button.

My Javascript for it :

$(document).ready(function() {
    $("#selectall").on("change", function(e) {
        $("input[type=checkbox]").prop("checked", $(this).prop("checked"));
    });
});

When my select all checkbox : <input type='checkbox' id='selectall' name='selectall'> is created on the same time than my HTML, it works.

But if I create my <input type='checkbox' id='selectall' name='selectall'> in my TABLE with my ajax function, it doesn't work, and nothing happens.

I'm pretty sure it is because the event is set to "selectall" at the load of the page but it doesn't exist yet and it doesn't look for it later.

What would be the solution ? Thanks for help

This might help:http://stackoverflow.com/questions/203198/event-binding-on-dynamically-created-elements — enhzflep, May 26 '15 at 14:56

Tushar · Accepted Answer · 2015-05-26T14:59:06.310

3

You can use event delegation as follow:

$('#devis').on("change", "#selectall", function(e) {
    $("input[type=checkbox]").prop("checked", $(this).prop("checked"));
});

edited May 26 '15 at 14:59

answered May 26 '15 at 14:57

Tushar

85,780
21
159
179

score 0 · Answer 2 · answered May 26 '15 at 15:00

You are right in your thinking :

If your selectall checkbox is created after the document ready code execution, jquery can't find it (as it's not created yet).

I won't recommand using the live function as it is deprecated and can be removed in futur version of jquery.

You can still use the on function but with a little modification :

$("#devis").on("change", "#selectall",function(e) {

Note that #mycontainer MUST exist on document load.

If you can't place a container, this will always work :

$("body").on("change", "#selectall",function(e) {

Event doesn't work when element isn't loaded directly

2 Answers2