vector erase-remove idiom compile error

Question

I have the following removeOneParam(Parameter* param) code which is from this answer:

class A
    {
        private:
          std::vector<Parameter*> params;
        public:
          void removeOneParam(Parameter* param)
          {
            params.erase(std::remove(params.begin(), params.end(), param), params.end());
          }
}

But I get the following compile error:

error: cannot convert ‘std::vector<Parameter*>::iterator {aka __gnu_cxx::__normal_iterator<Parameter**, std::vector<Parameter*> >}’ to ‘const char*’ for argument ‘1’ to ‘int remove(const char*)

How can I use that answer to my case?

You forgot to `#include ` – Baum mit Augen May 29 '15 at 14:01 — Baum mit Augen, May 29 '15 at 14:01

score 2 · Accepted Answer · answered May 29 '15 at 14:01

2

Your compiler is picking up the version of std::remove in the cstdio header, not the one you want. You're probably missing #include <algorithm>.

answered May 29 '15 at 14:01

TartanLlama

63,752
13
157
193

score 1 · Answer 2 · answered May 29 '15 at 14:01

1

It seems to me, that header algorithm is not included. Try to

#include <algorithm>

and then all should work fine.

answered May 29 '15 at 14:01

ForEveR

55,233
2
119
133

score 0 · Answer 3 · answered May 29 '15 at 14:11

0

Try to include at the top of your program include <algorithm>

That should make the errors disappear.

answered May 29 '15 at 14:11

Zero Tap

1
7

vector erase-remove idiom compile error

3 Answers3