C++ cin can't read in integers with 0 in them

Question

I was on hackerrank, and I ran into a very weird problem. The problem is "You are given an integer N. Find the digits in this number that exactly divide N (division that leaves 0 as remainder) and display their count. For N=24, there are 2 digits (2 & 4). Both of these digits exactly divide 24. So our answer is 2.". Here is my solution:

#include <cmath>
#include <cstdio>
#include <vector>
#include <iostream>
#include <algorithm>
using namespace std;

int main() {
/* Enter your code here. Read input from STDIN. Print output to STDOUT */
    int t, count;

    cin >> t;
    for (int i = 0; i < t; i++) {
        int n, copy;
        cout << "i: " << i << " ";
        cin >> n;
        cout << "n: " << n << " ";
        copy = n;
        count = 0;
        while (copy > 0) {
            if (n % (copy % 10) == 0)
                count++;
            copy = copy/10;
        }
        cout << "\n" << count << "\n";
    }  
    return 0;
}

t is the number of test cases, and n is the number to be tested. I can input any number I want into t without problems. However, if I input a number with a zero into n, I get a floating point exception error. The error occurs before the second cout statement. Other numbers work fine (so, for instance, 1024 gives an error, but 1124 is fine). I ran this code on the hackerrank website. Can someone please explain what is going on?

@user35443 yep! Using VS 2013 right now, but I'm not assuming the poster have access to a debugger. — cehnehdeh, Jun 09 '15 at 19:15
[This post](http://stackoverflow.com/questions/1081250/why-is-this-a-floating-point-exception) explains it. — cehnehdeh, Jun 09 '15 at 19:21

score 2 · Answer 1 · edited May 23 '17 at 12:22

Floating point exception usually occurs when attempting to do an illegal arithmetic operation. (Check this) In your example you will end up doing modulo 0 which is undefined behaviour. Most runtimes will bail out with some kind of runtime error. Here is the output that gdb gives on running your code with following input:

1 10

Program received signal SIGFPE, Arithmetic exception.
0x0000000000400920 in main () at a.cpp:21
21              if (n % (copy % 10) == 0)

Try remodelling your algorithm so that you do not end up doing that.

(I would suggest learning debugging tools and running your code through them to catch such issues)

Regarding why the line was not printed, that's because most implementations of cin and cout are buffer based (Read this for more on buffered i/o). Had you added a "std::endl" after cout you could have seen the output coming. Or you could have used std::cerr for outputting debug info. std::cerr has more stringent requirements laid down by the standard to flush more diligently. In your case before the buffer could be flushed the application terminated.

Ok, I understand that. But why wasn't n printed out? The line came before the modulo, so it should have been executed. — alexgbelov, Jun 09 '15 at 19:35

score 1 · Accepted Answer · edited May 23 '17 at 11:43

1

You can't mod divide by 0. Try to redesign your algorithm so that you avoid trying to perform that operation. Perhaps check copy % 10 == 0 then just skip that case. The reason that it is a floating point exception and not a divide by zero exception is described in this stack exchange post

edited May 23 '17 at 11:43

Community

1
1

answered Jun 09 '15 at 19:16

Joseph Hutchinson

321
1
10

Yeah, but why was the `floating-point exception` risen instead of `0x0 - divison by zero`? – user35443 Jun 09 '15 at 19:18
2

see [this post](http://stackoverflow.com/questions/1081250/why-is-this-a-floating-point-exception) – Joseph Hutchinson Jun 09 '15 at 19:20
@user35443 the OP actually had an `exception error` which is unclear to what they actually got. – NathanOliver Jun 09 '15 at 19:22
@user35443 bashrc's response shows a SIGx. If this is not the problem you are having OP then please let us know. – Joseph Hutchinson Jun 09 '15 at 19:27
Ok, thank you. Question: why does it appear that cin was causing the problem? The line "cout << "n: " << n << " ";" should have still been executed, since the exception doesn't happen until the modulo. – alexgbelov Jun 09 '15 at 19:34

score 1 · Answer 3 · answered Aug 29 '15 at 13:51

Your code will work just fine when you enter any no. without any 0 digit in it .The problem in your code is that you are trying to divide the number by 0.

       **if (n % (copy % 10) == 0)**

In this when we enter any no with 0 as a digit then the value of (copy%10) becomes 0.Thus it tries to divide n by 0 thus throwing an floating point exception error. Change your code like this :

Declare a new variable named 'r'.This will prevent execution of the command when we get 0 as a digit.Thus the program will run just fine

while(copy!=0)
        {`enter code here`
            r=copy%10;
            if(r!=0)
            {
                if(n % r==0)
                count++;
            }
            copy=copy/10;
        }
        cout<<count<<endl;

score 0 · Answer 4 · answered Jun 09 '15 at 19:18

0

You can't mod something by 0. Check to make sure copy is nonzero.

answered Jun 09 '15 at 19:18

coryknapp

69
4

C++ cin can't read in integers with 0 in them

4 Answers4