Is it good practise to use angular.element("[ng-controller="someCtrl"]").scope()

Question

Is it good practise to use angular.element("ng-controller="someCtrl"]").scope() instead of using factory to handle data flow between controllers using dependency injection. The problem here is I want to call a function of another controller, so there are two ways either I put it in a factory and reuse it among controllers or use above syntax to call the function directly.

score 2 · Answer 1 · answered Jun 10 '15 at 08:59

2

It is never good practice to access the DOM from a controller. So if wrapping the method in a factory/service is an option, I'd say that's the way to go.

answered Jun 10 '15 at 08:59

Thor Jacobsen

8,621
2
27
26

score 2 · Accepted Answer · edited May 23 '17 at 12:30

If you need to call a function from other controller, it should be a SERVICE/Factory. This way, you will share code between controllers, and you will code with good practices.

As they say in angularjs docs

Angular services are substitutable objects that are wired together using dependency injection (DI). You can use services to organize and share code across your app.

Then, you just need to create a service or a factory

//The service
angular.module('myApp')
  .service('serviceName', function ($http, $scope, socket) {
 //This functions will be available in your controller
    return {
      list: function () {
        $http.get(listUrl).success(function (lista) {
          $scope.centerList = lista;
          socket.syncUpdates('center', $scope.centerList);
        });
      }
    };
  });

//The controller
angular.module('myApp').controller('myCtrl', function ($scope, centerService) {

$scope.listCenters = function () {
  centerService.list();
};
});

Just to clarify, and to add some comprehensive ideas about services and factories:

Is it good practise to use angular.element("[ng-controller="someCtrl"]").scope()

2 Answers2