Validating currency allows more than two decimal places

Question

Situation:

I'm writing a Winforms app using C# in VS2013 with .NET4.0.

Some cells in a datagridview need to be validated as correctly formatted UK currency values. The dgv cell format is set to currency with two decimal places. For validation I'm using the following code:

decimal convertedCurrency;

if (decimal.TryParse(dataGrid.Rows[e.RowIndex].Cells[e.ColumnIndex].EditedFormattedValue.ToString(), NumberStyles.Currency, null, out convertedCurrency))
{
    if (convertedCurrency > columnDetails.MaxValue || convertedCurrency < 0)
    {
        this.ReportError(dataGrid, e, dataGrid.Columns[e.ColumnIndex].HeaderText + " must be between £0 and £" + columnDetails.MaxValue);
    }
}
else
{
    this.ReportError(dataGrid, e, "Incorrect format for a money value");
}

Issue:

This works prefectly except if the user inputs a value with more than two decimal places e.g. 100.001. This is deemed valid and this value is written to the database.

Question:

How can I best validate such that user input with more than two decimal places caught and handled? I could of course get into some messy string handling but is there a more ellegant way, ideally continuing to use TryParse?

See http://stackoverflow.com/questions/13477689/find-number-of-decimal-places-in-decimal-value-regardless-of-culture to find the number of decimal places. Just verify that it's <= 2. — Jared Moore, Jun 12 '15 at 17:59
Really helpful @JaredMoore. I'd upvote you if this was in answers rather than comments. — ifinlay, Jun 13 '15 at 09:31

score 1 · Answer 1 · answered Jun 12 '15 at 18:24

1

Three possible solutions I would suggest:

1) Use a MaskedTextBox to avoid the problem from the start

2) Create a keyup event to parse/check the input for correct formatting

3) use regex on the input: ^[0-9].[0-9]{2}$ or ^[0-9].[0-9][0-9]$

answered Jun 12 '15 at 18:24

SteveFerg

3,466
7
19
31

score 1 · Accepted Answer · edited May 23 '17 at 11:43

1

See Find number of decimal places in decimal value regardless of culture to find the number of decimal places. Just verify that it's <= 2.

e.g.

decimal value = 123.456m;
if (GetDecimalPlaces(value) > 2)
{
    // Error
}

int GetDecimalPlaces(decimal d)
{
    int count = BitConverter.GetBytes(decimal.GetBits(argument)[3])[2];
}

edited May 23 '17 at 11:43

Community

1
1

answered Jun 14 '15 at 17:58

Jared Moore

3,765
26
31

Validating currency allows more than two decimal places

2 Answers2