Is there a way to shorten my if(word.Contains("tree") ||word.Contains("water")||word.Contains("sky"))

Question

Pretty much what the title says, I got a big if-sentence with ~5Contains this is not nicely looking if I repeat this a few times, is there any way to shorten this?

if(word.Contains("tree") ||word.Contains("water")||word.Contains("sky")||word.Contains("lake")||word.Contains("plant"))
{
//do something
}

Answer 1

Just define an array with the terms and use a LINQ expression:

string[] searchTerms = { "tree", "water", ...}

if (searchTerms.Any(p => word.Contains(p)) {
  // do something
}

Answer 2

You can do this:

if (new [] { "tree", "water", "sky", "lake", "plant", }.Any(w => word.Contains(w)))
{
//do something
}

Answer 3

Yes, but the keywords in an array, and switch it round

var words = new[]{"tree","water","sky","lake"};
if(words.Any(w => word.Contains(w))){
  // do something
}

Answer 4

You can use regex for this:

if (Regex.IsMatch(word, "tree|water|sky|lake|plant")) {
    // Do something
}

This approach is more flexible than using Contains, because it lets you find whole-word matches (i.e. match "tree" but not "subtree", or "plant" but not "implant")

if (Regex.IsMatch(word, @"\b(tree|water|sky|lake|plant)\b")) {
    // Do something
}

Answer 5

There are probably a dozen or more ways you could code this. I'm not really sure I would worry about making it shorter code, so much as I would worry about making it maintainable and readable. Something like this, perhaps:

var wordsToCheck = new[] { "tree", "water", "sky", "lake" };
if (wordsToCheck.Any(wordToCheck => word.Contains(wordToCheck)))
{

}

Answer 6

looks like others beat me. But you can make it very short using a method group.

var strs = new[] { "tree", "water", "sky", "lake", "plant" };

if(strs.Any(word.Contains))
{

}

Answer 7

You can use split then Any

if("tree,water,sky,lake,plant".Split(',').ToList().Any(e=>word.Contains(e)))