Android How to Call Method From Another Class

Question

Right now I'm working on app that will draw line on onClick. I'm drawing line in LineView.java class and performing onClick method in MainActivity.java. To solve this problem I have checked similar questions. The first solution:

LineView.onDraw();

It gives me this error:

Multiple markers at this line
    - The method onDraw(Canvas) in the type LineView is not applicable for the 
     arguments ()
    - Suspicious method call; should probably call "draw" rather than "onDraw"

Also I tried to write in MainActivity:

LineView lineView = new LineView(null);
lineView.onDraw();

But it also gives an error:

Multiple markers at this line
    - The method onDraw(Canvas) in the type LineView is not applicable for the 
     arguments ()
    - Suspicious method call; should probably call "draw" rather than "onDraw"

Here's my LineView.java:

public class LineView extends View {
Paint paint = new Paint();
Point A;
Point B;
boolean draw = false;

public void onCreate(Bundle savedInstanceState) {

}

public LineView(Context context, AttributeSet attrs) {
  super(context, attrs);
  }

public LineView(Context context, AttributeSet attrs, int defstyle) {
super(context, attrs, defstyle );
  }


public LineView(Context context) {
super(context);
paint.setColor(Color.BLACK);
}

@Override
public void onDraw(Canvas canvas) {
    draw = MainActivity.draw;
    if(draw){
    //A = (getIntent().getParcelableExtra("PointA"));
    A = MainActivity.A;
    B = MainActivity.B;

    canvas.drawLine(A.x, A.y, B.x, B.y, paint);
    }
}

private Intent getIntent() {
    // TODO Auto-generated method stub
    return null;
}

}

My MainActivity.java onClick:

 @Override
       public void onClick(View v) {
           draw = true;
                       LineView.onDraw();
                     }
   });

Thanks in advance!

have you added thew LineView to any layout or init the LineView dynamicly? — Itzik Samara, Jun 20 '15 at 18:02

score 0 · Answer 1 · answered Jun 21 '15 at 03:32

0

You are not supposed to call onDraw() on any View directly. Views draw themselves if they are visible and in the view hierarchy. If you need the view to draw itself because something has changed (like your A and B variables), then you should do something like this :

LineView.invalidate();

invalidate() tells the UI system that the view has changed and onDraw() should be called at some point in the near future (probably the next iteration of the UI thread).

I think your 'draw' variable is probably unnecessary. If you want to hide the view sometimes, then use setVisibility() instead.

answered Jun 21 '15 at 03:32

Joel Duggan

215
1
7

This is not working. It says that it cannot make a static reference to the non-static method invalidate() from the type View. Can't I somehow use onDraw() in MainActivity? – Oleksandr Firsov Jun 21 '15 at 06:45
You need to call invalidate on an instance of the LineView class, not the class itself. If you don't have a reference to your LineView object, then you can get it from your layout this way `(LineView)mainView.findViewById(R.id.id_of_LineView);` – Joel Duggan Jun 21 '15 at 12:35
See here also : [link](http://stackoverflow.com/questions/3903537/i-want-to-know-the-difference-between-static-method-and-non-static-method) – Joel Duggan Jun 21 '15 at 12:40

Android How to Call Method From Another Class

1 Answers1