What wrong with my code in this case causing "Program has unexpectedly stopped"?

Question

Here I am trying to practice using Spinner both in XML and JAVA. Specificially, I made a program which showing Toast about tea, style, flava, topping chosen. I did check with another more simple version of this program before progressing in this step, everything was running smoothly at that point. However then, it's so confusing. In fact, I am not experienced enough to find out what went wrong. Please help a newbie, the code may be a little bit long I would be very, very thankful

package com.example.second_spinner;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import android.app.Activity;
import android.os.Bundle;
import android.view.View;
import android.widget.AdapterView;
import android.widget.AdapterView.OnItemSelectedListener;
import android.widget.ArrayAdapter;
import android.widget.Spinner;
import android.widget.Toast; 

public class Second_Spinner extends Activity {
    private String tea_message = "";
    private String style_message = "";
    private String flava_message = "";
    private String moreLove_message = "";
    private String message = getString(R.string.message);
    private int maximum_flava = 4;
    private ArrayList<String> alreadyFlava = new ArrayList<String>();
    private ArrayList<String> alreadyLove = new ArrayList<String>();


    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);;
        setContentView(R.layout.activity_second__spinner);

        Spinner spinner1 = (Spinner) findViewById(R.id.spinner1);
        Spinner spinner2 = (Spinner) findViewById(R.id.spinner2);

        spinner1.setOnItemSelectedListener(new MilkTea());
        spinner2.setOnItemSelectedListener(new MilkTea());

        Spinner spinner3 = (Spinner) findViewById(R.id.spinner3);
        Spinner spinner4 = (Spinner) findViewById(R.id.spinner4);

        List<String> flava = getFlava();
        ArrayAdapter<String> spinnerAdapter1 = new ArrayAdapter<String>(this,android.R.layout.simple_spinner_item,flava);
        spinnerAdapter1.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
        spinner3.setAdapter(spinnerAdapter1);
        spinner3.setOnItemSelectedListener(new MilkTea());

        List<String> moreLove = getMoreLove();
        ArrayAdapter<String> spinnerAdapter2 = new ArrayAdapter<String>(this,android.R.layout.simple_spinner_item,moreLove);
        spinnerAdapter2.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
        spinner4.setAdapter(spinnerAdapter2);
        spinner4.setOnItemSelectedListener(new MilkTea());
    }



    private class MilkTea implements OnItemSelectedListener {
        private boolean isFirst;

        public void onItemSelected(AdapterView<?> spinner, View selectedView, int selectedIndex, long id) {
            if (isFirst == false) {
                isFirst = true;
            }
            else {
                switch (selectedView.getId()) {

                    case (R.id.spinner1) :
                        tea_message = spinner.getItemAtPosition(selectedIndex).toString();
                        break;

                    case (R.id.spinner2) :
                        style_message = spinner.getItemAtPosition(selectedIndex).toString();
                        break;

                    case (R.id.spinner3) :
                        if (maximum_flava > 0) {
                            if (alreadyFlava.isEmpty()) {
                                flava_message = spinner.getItemAtPosition(selectedIndex).toString();
                                alreadyFlava.add(flava_message);
                                maximum_flava--;
                            }
                            else {
                                boolean sign = true;
                                String temp = spinner.getItemAtPosition(selectedIndex).toString();
                                for (int i = 0; i < alreadyFlava.size(); i++)
                                    if (temp.equals(alreadyFlava.get(i))) {
                                        sign = false;
                                        break;
                                    }
                                if (sign == true) {
                                    flava_message += ","+temp;
                                    alreadyFlava.add(flava_message);
                                    maximum_flava--;
                                }
                            }
                        }   
                        break;

                    case (R.id.spinner4) :
                        if (alreadyLove.isEmpty()) {
                            moreLove_message = spinner.getItemAtPosition(selectedIndex).toString();
                            alreadyFlava.add(flava_message);
                        }
                        else {
                            boolean sign = true;
                            String temp = spinner.getItemAtPosition(selectedIndex).toString();
                            for (int i = 0; i < alreadyLove.size(); i++)
                                if (temp.equals(alreadyLove.get(i))) {
                                    sign = false;
                                    break;
                                }
                            if (sign == true) {
                                moreLove_message += ","+temp;
                                alreadyLove.add(moreLove_message);
                            }
                        }
                        break;
                }
                message = String.format(message, tea_message, style_message, flava_message, moreLove_message);
                Toast.makeText(getBaseContext(), message, Toast.LENGTH_SHORT).show();
            }
        }

        public void onNothingSelected(AdapterView<?> spinner) {

        }
    }



    private List<String> getFlava() {
        String[] flava = {
                "No, I'm good", "Honeydew", "Blood Orange", "Red Guava", "Kumquat", "Lychee", "Longan", "Blackberry",
                "Pineapple", "Mango", "Passion Fruit", "Taro", "Strawberry", "Coconut"
        };
        List<String> flava_list = Arrays.asList(flava);
        return flava_list;
    }



    private List<String> getMoreLove() {
        String[] moreLove = {
                "Not Today","Aloe Vera","Black Pearls", "Coffee Jelly","White Pearls","Grass Jelly","Passion Jelly",
                "Coconut Jelly","Lychee Jelly","Strawberry Jelly","Manga Jelly","Manga Stars"
        };
        List<String> moreLove_list = Arrays.asList(moreLove);
        return moreLove_list;
    }


}

score 1 · Accepted Answer · edited May 23 '17 at 10:26

private String message = getString(R.string.message);

You're accessing resources too early. You cannot access resources at activity construction time e.g. when initializing member variables. You need to wait until onCreate() in the activity lifecycle. Move the getString() there.

Generally, to learn what went wrong, see the exception stacktrace in logcat. Include it in your questions, too. See Unfortunately MyApp has stopped. How can I solve this?

What wrong with my code in this case causing "Program has unexpectedly stopped"?

1 Answers1