Combo box not working windows form

Question

I"m trying to add items to my combobx but it"s not working:

static ArrayList bandlist = new ArrayList();

public addBand()
{
    InitializeComponent();
    bandlist[0] = "test";
    bandlist[1] = "test";
    fillComboBox();
}



public void fillComboBox()
{
    foreach (string item in bandlist)
    {
        combo.Text = item;
    }
}

Thank you

Look over the properties of ComboBox. You'll find one that is more appropriate. — H H, Jun 29 '15 at 12:01
Can you please be more specific about _not working_? You get any exception or error message? — Soner Gönül, Jun 29 '15 at 12:01
Extending @HenkHolterman comment: `ComboBox.Text` is not the right property to *add items*. — Sinatr, Jun 29 '15 at 12:02

score 1 · Answer 1 · answered Jun 29 '15 at 12:01

To add items to your combobox, you have to fill the .Items property (which is a collection). See https://msdn.microsoft.com/en-us/library/aa983551(v=vs.71).aspx

You're currently using the Text property:

Setting the Text property to null or an empty string ("") sets the SelectedIndex to -1. Setting the Text property to a value that is in the Items collection sets the SelectedIndex to the index of that item. Setting the Text property to a value that is not in the collection leaves the SelectedIndex unchanged.

score 0 · Answer 2 · answered Jun 29 '15 at 12:02

0

You are setting the wrong property. You should set the Items Or DataSource property for entering all the values inside the control.

    combo.DataSource= bandlist;

OR

    foreach (var item in bandlist)
    {
      combo.Items.Add(item);
    }

answered Jun 29 '15 at 12:02

Schuere

1,579
19
33

score 0 · Answer 3 · answered Jun 29 '15 at 12:02

0

Maybe you need:

combo.Items.Add(item);

answered Jun 29 '15 at 12:02

malhotraprateek

96
9

Thankyou but when I do this it's empty. I"m receiving it now from an array but it's empty very strange. – Jamie Jun 29 '15 at 12:08
Seems like I was in a hurry. Check this out: [link](http://stackoverflow.com/questions/3063320/combobox-adding-text-and-value-to-an-item-no-binding-source) – malhotraprateek Jun 29 '15 at 12:11

score 0 · Answer 4 · edited May 23 '17 at 12:30

0

To add an item to the combobox you should use the Items.Add method.

combo.Items.Add(item);

Also, I note that you use an ArrayList. Unless you're using the version 1 of the framework, I'd recommand to use a generic collection such as List<string>.

Look at ArrayList vs List<> in C# to see advantages of generic collections over ArrayList

edited May 23 '17 at 12:30

Community

1
1

answered Jun 29 '15 at 12:06

Tom C.

593
4
12

Combo box not working windows form

4 Answers4