Android Java NullPointerException with saveText in MainActivity

Question

I have a NullPointerException when try to use saveText in MainActivity I'm a noob in OOP and Java, and I can't understand what I'm doing wrong. Thank you for help.

public class FileIO extends Activity{

    FileInputStream fin;
    FileOutputStream fos;

    public void SaveFile(String FileName, String FileData) {
        try {
            fos = openFileOutput(FileName, MODE_PRIVATE);
            fos.write(FileData.getBytes());
            Toast.makeText(this, "Файл "+FileName+" сохранен", Toast.LENGTH_SHORT).show();
        }
        catch(IOException ex) {
            Toast.makeText(this, ex.getMessage(), Toast.LENGTH_SHORT).show();
        }
        finally{
            try{
                if(fos!=null) {
                    fos.close();
                }
            }
            catch(IOException ex){
                Toast.makeText(this, ex.getMessage(), Toast.LENGTH_SHORT).show();
            }
        }
    }

    public String ReadFile(String FileName) {
        String text = "";

        try {
            fin = openFileInput(FileName);
            byte[] bytes = new byte[fin.available()];
            fin.read(bytes);
            text = new String (bytes);
        }
        catch(IOException ex) {
            Toast.makeText(this, ex.getMessage(), Toast.LENGTH_SHORT).show();
        }
        finally {
            try {
                if (fin != null) {
                    fin.close();
                }
            } catch (IOException ex) {
                Toast.makeText(this, ex.getMessage(), Toast.LENGTH_SHORT).show();
            }
        }

        return text;
    }
}


public class MainActivity extends ActionBarActivity {

    FileInputStream fin;
    FileOutputStream fos;

    FileIO FL = new FileIO();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    }
    // сохранение файла
    public void saveText(View view){
        try {
            EditText textBox = (EditText) findViewById(R.id.save_text);
            String text = textBox.getText().toString();

            FL.SaveFile("content.txt", text);
        }
        catch(Exception ex) {
            Toast.makeText(this, "Ошибка записи файла", Toast.LENGTH_SHORT).show();
            Log.d("MyLog", ex.toString() + "\n" + ex.getMessage() + "\n" + ex.getCause());
        }
    }
    // открытие файла
    public void openText(View view){

        TextView textView = (TextView) findViewById(R.id.open_text);
        try {
            fin = openFileInput("content.txt");
            byte[] bytes = new byte[fin.available()];
            fin.read(bytes);
            String text = new String (bytes);
            textView.setText(text);
        }
        catch(IOException ex) {

            Toast.makeText(this, ex.getMessage(), Toast.LENGTH_SHORT).show();
        }
        finally{

            try{
                if(fin!=null)
                    fin.close();
            }
            catch(IOException ex){

                Toast.makeText(this, ex.getMessage(), Toast.LENGTH_SHORT).show();
            }
        }
    }
}

nullpointerexception means you have done something wrong in your xml. — Chaudhary Amar, Jun 30 '15 at 13:22
possible duplicate of [What is a Null Pointer Exception, and how do I fix it?](http://stackoverflow.com/questions/218384/what-is-a-null-pointer-exception-and-how-do-i-fix-it) — Stephen Kennedy, Jun 30 '15 at 13:54

score 2 · Accepted Answer · answered Jun 30 '15 at 13:34

2

Don't extend your class FileIO from Activity.

Change your code from

public class FileIO extends Activity{

to

public class FileIO{

Pass "MainActivity" context to FileIO class in constructor while creating object and use it to display Toast message.

 FileIO fileIo= new FileIO(MainActivity.this);

Hope this will helpfull for your

answered Jun 30 '15 at 13:34

Raghu Mudem

6,793
13
48
69

It helps. Thank you. I am really forgot about context! – Mongolor Jun 30 '15 at 14:51

Android Java NullPointerException with saveText in MainActivity

1 Answers1