Shared Preferences on a Null Object Reference Android

Question

I am new to android developing maybe its a silly question but please help me. I am getting this error while trying to save an int value.

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.SharedPreferences android.content.Context.getSharedPreferences(java.lang.String, int)' on a null object reference

And here is my code

SharedPreferences prefs = this.getSharedPreferences("com.example.app", Context.MODE_PRIVATE);
String value = "com.example.app.value";
int i = prefs.getInt(value, 0);

And for write

prefs.edit().putInt(number, i).apply();

I just want to set a SharedPreferences and want to read it at the first and write it inside the Activity. How can I solve it?

EDIT

public class MainActivity extends Activity {
SharedPreferences sharedpreferences;
public static final String MyPREFERENCES = "myprefs";
public static final  String value = "key";

int i = sharedpreferences.getInt(value, 0);

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    sharedpreferences = getSharedPreferences(MyPREFERENCES, Context.MODE_PRIVATE);
}
public void sendMessage(View view) {
    i += 1;    
    SharedPreferences.Editor editor = sharedpreferences.edit();
    editor.putInt(value, i);
    editor.apply();
}

I managed to save preferences with a different way but I couldn't manage to read it in MainActivity extends Activity class.

log :

Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'int android.content.SharedPreferences.getInt(java.lang.String, int)' on a null object reference

`SharedPreferences prefs = yourActivity.this.getSharedPreferences("com.example.app", Context.MODE_PRIVATE);` — M D, Jun 30 '15 at 15:24
^ yourActivity.this.getSharedPreferences() has no effect compared to directly calling getSharedPreferences(), since the provided code is already in the activity; you would only do it this way if you were in a utility class (in which case calling getSharedPreferences() directly wouldn't even compile). Also it is bad practice to hardcode the package name (this is a magic string), call getPackageName() instead. — OldSchool4664, Feb 02 '18 at 18:36

Anand Singh · Accepted Answer · 2015-06-30T17:17:39.967

19

This is an example of SharedPreferences

To save name in SharedPreferences:

SharedPreferences sharedPreferences = PreferenceManager
                .getDefaultSharedPreferences(this);
        Editor editor = sharedPreferences.edit();
        editor.putString(key, name);
        editor.apply();

To get name from SharedPreferences:

 SharedPreferences sharedPreferences = PreferenceManager
                .getDefaultSharedPreferences(this);
        String name = sharedPreferences.getString(key, "default value");

For more details visit: http://developer.android.com/training/basics/data-storage/shared-preferences.html

Updated Code:

public class MainActivity extends Activity {
SharedPreferences sharedpreferences;
public static final String MyPREFERENCES = "myprefs";
public static final  String value = "key";

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    sharedpreferences = getSharedPreferences(MyPREFERENCES, Context.MODE_PRIVATE);
    int i = sharedpreferences.getInt(value, 0);
    //use the value of i where needed.
}
public void saveMessage(View view) {
    i += 1;    
    SharedPreferences.Editor editor = sharedpreferences.edit();
    editor.putInt(value, i);
    editor.apply();
}

edited Jun 30 '15 at 17:17

answered Jun 30 '15 at 15:37

Anand Singh

5,672
2
23
33

use .apply() instead of commit() – Douglas Fornaro Jun 30 '15 at 16:08
2

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.content.Context.getPackageName()' on a null object reference getting this error now – Simbilli Dev Jun 30 '15 at 16:22
@SimbilliDev please post whole code of your activity in your question post. I will correct it. – Anand Singh Jun 30 '15 at 16:47
Thanks for help. I found an other way to solve but this one also worked – Simbilli Dev Jun 30 '15 at 17:29
Yes, there are many ways to use SharedPreferences. You will get more details about it in the link mentioned in my answer. – Anand Singh Jun 30 '15 at 17:31

score 3 · Answer 2 · answered Feb 13 '22 at 16:58

3

In my case this was the issues : https://stackoverflow.com/a/43160497/321015

I was calling shared prefereance before context was set. ideal way to call the context

newContextbase.getSharedPreferences(..

answered Feb 13 '22 at 16:58

Black Diamond

361
5
16

score 2 · Answer 3 · edited Jan 22 '19 at 00:18

You can implement it like this

public class PreferenceClass {
    public static final String PREFERENCE_NAME = "PREFERENCE_DATA";
    private final SharedPreferences sharedpreferences;

    public PreferenceClass(Context context) {
         sharedpreferences = context.getSharedPreferences(PREFERENCE_NAME, Context.MODE_PRIVATE);
    }

    public int getCount() {
         int count = sharedpreferences.getInt("count", -1);
         return count;
    }

    public void setCount(int count) {
         SharedPreferences.Editor editor = sharedpreferences.edit();
         editor.putInt("count", count);
         editor.commit();
    }

    public void clearCount() {
         SharedPreferences.Editor editor = sharedpreferences.edit();
         editor.remove("count");
         editor.commit();
    }
}

getCount() will return -1 if no value is set.

score 2 · Answer 4 · answered Sep 01 '19 at 14:52

2

This question was for the "Simplify Networking with RetroFit" android course. I was getting this error because i didnt have my BaseApplication class in the Android Manifest...Everything is good now

answered Sep 01 '19 at 14:52

Mehdi Abiyat

21
3

Suffering with this error for two days. After reading your answer only I noticed I did not put my base application class in my manifest. Working good now – deluxan Feb 07 '20 at 08:54

Shared Preferences on a Null Object Reference Android

4 Answers4