Get value from Android listview and put it in extra

Question

In my code below I created a method which is: I would like to put a variable in putExtra that I can get it in the new activity. The problem is in the new activity gave me the first value(numtelephone) from first element in my list. I know that because of getItem(0), but how can I get the value( numtelephone ) for every element from the list?

public class ListClient extends Activity {
    String myJSON,test; 
  TextView numt;
    private static final String TAG_RESULTS="result";
    private static final String TAG_NOMCLIENT = "nomclient";
    private static String TAG_NUMTELEPHONE ="numtelephone";
    private static final String TAG_DEPART ="depart";
    private static final String TAG_DESTINATION ="destination";
    private static final String TAG_NBRPERSONNE ="nbrpersonne";  
    JSONArray peoples = null;
    ArrayList<HashMap<String, String>> personList;

ListView list;
@SuppressLint("NewApi")
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_list_client);
        list = (ListView) findViewById(R.id.list);
        personList = new ArrayList<HashMap<String,String>>();
        getData();
    }

    protected void showList(){
            //json parsing etc...

            ListAdapter adapter = new SimpleAdapter(
                    ListClient.this, personList, R.layout.list_item,
                    new String[]{TAG_NOMCLIENT,TAG_NUMTELEPHONE,TAG_DEPART,TAG_DEPART,TAG_NBRPERSONNE},
                    new int[]{R.id.name, R.id.numt, R.id.depart, R.id.destination, R.id.nbrpersonne}
            );
            list.setAdapter(adapter);
    }

    public void getData(){
        class GetDataJSON extends AsyncTask<String, Void, String>{

            @Override
            protected String doInBackground(String... params) {
               // json dowload from web, not needed in this question
               return ""; 
            }

            @Override
            protected void onPostExecute(String result){
                myJSON=result;
                showList();
            }
        }
        GetDataJSON g = new GetDataJSON();
        g.execute();

    }

    public void GoUpdate(View v ) {
        Intent in = new Intent(getBaseContext(), Update.class);
            in.putExtra("NUMTELEPHONE",((HashMap<String, String>)list.getAdapter().getItem(0)).get("numtelephone"));
        }

        startActivity(in);
    }
}

Answer 1

There is simple and only one solution. Delete your xml android:click property of list and add this list#setOnItemClickListener in your onCreate:

protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_list_client);
    list = (ListView) findViewById(R.id.list);
    personList = new ArrayList<HashMap<String,String>>();
    getData();

    //this thing has been added
    list.setOnItemClickListener(new AdapterView.OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            if(id!=-1){
            Intent in = new Intent(getBaseContext(), Update.class);
            in.putExtra("NUMTELEPHONE", ((HashMap<String, String>) list.getAdapter().getItem((int)id)).get("numtelephone")); //TAG_NUMTELEPHONE

            startActivity(in);
            }
        }
    });
}

To move it from onCreate do:

   @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_list_client);
        list = (ListView) findViewById(R.id.list);
        personList = new ArrayList<HashMap<String, String>>();
        getData();
        list.setOnItemClickListener(new OnMyListItemClickListener());
    }

    Context context = this;

    private class OnMyListItemClickListener implements AdapterView.OnItemClickListener {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            if(id!=-1){
            Intent in = new Intent(context, Update.class);
            in.putExtra("NUMTELEPHONE", ((HashMap<String, String>) list.getAdapter().getItem((int) id)).get("numtelephone")); //TAG_NUMTELEPHONE

            startActivity(in);
            }
        }
    }

---

Lesson learned - dont create sucha buttons - they are not aware in which item they are, so you cant extract the id - instead just use something like AlertDialog

  public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
        if(id!=-1){
        AlertDialog.Builder al = new AlertDialog.Builder(context);
        al.setMessage("Are you sure you want to do it?");
        al.setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() {
            @Override
            public void onClick(DialogInterface dialogInterface, int i) {
                Intent in = new Intent(context, Update.class);
                in.putExtra("NUMTELEPHONE", ((HashMap<String, String>) list.getAdapter().getItem((int) id)).get(TAG_NUMTELEPHONE));

                startActivity(in);
            }
        });
        al.setNegativeButton(android.R.string.no, null);
        al.show(); 
        }        
    }