0

In my routes/index.js file, I have:

var mongoose = require('mongoose/');

...

var schema = mongoose.Schema;
var user_details = new schema(
  { 
  username: String, 
  password: String
  },
  {
  collection: 'userInfo'
  });

router.post('/newuser', function(request, response, next)
  {
  var newuser = new user_details(
    {
    'username': request.params.username,
    'password': request.params.password
    });
  newuser.save();
  response.redirect('/');
  });

This is giving the error below. The 48:17 location is the "new" in the "var newuser = new user_details(" line:

object is not a function

TypeError: object is not a function
    at module.exports (/Users/jonathan/server/routes/index.js:48:17)
    at Layer.handle [as handle_request] (/Users/jonathan/server/node_modules/express/lib/router/layer.js:82:5)
    at next (/Users/jonathan/server/node_modules/express/lib/router/route.js:110:13)
    at Route.dispatch (/Users/jonathan/server/node_modules/express/lib/router/route.js:91:3)
    at Layer.handle [as handle_request] (/Users/jonathan/server/node_modules/express/lib/router/layer.js:82:5)
    at /Users/jonathan/server/node_modules/express/lib/router/index.js:267:22
    at Function.proto.process_params (/Users/jonathan/server/node_modules/express/lib/router/index.js:321:12)
    at next (/Users/jonathan/server/node_modules/express/lib/router/index.js:261:10)
    at Function.proto.handle (/Users/jonathan/server/node_modules/express/lib/router/index.js:166:3)
    at router (/Users/jonathan/server/node_modules/express/lib/router/index.js:35:12)
    at Layer.handle [as handle_request] (/Users/jonathan/server/node_modules/express/lib/router/layer.js:82:5)
    at trim_prefix (/Users/jonathan/server/node_modules/express/lib/router/index.js:302:13)
    at /Users/jonathan/server/node_modules/express/lib/router/index.js:270:7
    at Function.proto.process_params (/Users/jonathan/server/node_modules/express/lib/router/index.js:321:12)
    at next (/Users/jonathan/server/node_modules/express/lib/router/index.js:261:10)
    at SessionStrategy.strategy.pass (/Users/jonathan/server/node_modules/passport/lib/middleware/authenticate.js:318:9)

My understanding of "object is not a function" is that some object has (attemptedly) been called as a function, such as {0: false, 1: true}(). But can you explain what in my code is triggering my error?

--UPDATE--

I think I'm doing what was suggested in the answer's first comment. The error I'm getting now is:

/Users/jonathan/node_modules/mongoose/lib/index.js:340
      throw new mongoose.Error.OverwriteModelError(name);
            ^
OverwriteModelError: Cannot overwrite `userInfo` model once compiled.

The triggering line of code is:

var user = mongoose.model('userInfo', user_details);
Christos Hayward
  • 5,777
  • 17
  • 58
  • 113
  • user_details is a schema, not a model. you missed one important step in setting up your model. http://mongoosejs.com/docs/guide.html – Kevin B Jul 02 '15 at 21:44
  • On a side note, passing `function (req, res, next)` is usually more idiomatic for express. I also suggest following the [airbnb javascript style guide](https://github.com/airbnb/javascript). – royhowie Jul 02 '15 at 21:54

1 Answers1

4

The error is being triggered because a schema cannot be instantiated and used as a model. You need to make it a mongoose model first with mongoose.model('DocumentName', document).

For example (I'm copypasta'ing part of this from a current project, so it's ES6):

// user.js
import mongoose from 'mongoose'

let userSchema = mongoose.Schema({
    password: String,
    username: String
})

userSchema.methods.setUp = function (username, password) {
    this.username = username
    this.password = password
    return this
}

export let User = mongoose.model('User', userSchema)
export default User

// routes.js
import { User } from './models/user'

router.post('/newuser', function (req, res) {
    new User()
    // note the `setUp` method in user.js
    .setUp(req.params.username, req.params.password)
    .save()
    // using promises; you can also pass a callback
    // `function (err, user)` to save
    .then(() => { res.redirect('/') })
    .then(null, () => /* handle error */ })
})
royhowie
  • 11,075
  • 14
  • 50
  • 67
  • Thank you. I have the model represented in the database and it's throwing an error. How can I retrieve, or make something compatible with, an existing model represented in Mongoose? – Christos Hayward Jul 02 '15 at 21:56
  • @JonathanHayward You need to make the schema a model: `var User = mongoose.model('User', user_details)`. Then, you can use `new User()` instead of `new user_details(…)` – royhowie Jul 02 '15 at 21:58
  • @JonathanHayward did you end up solving your problem? – royhowie Jul 06 '15 at 04:08
  • Not yet; I haven't exhausted the resources but am opting for node-localstorage, which should be more familiar to my readers and to me. – Christos Hayward Jul 07 '15 at 12:05
  • @JonathanHayward can you link to your code (a github gist or something); from your update, it's hard to tell what could be causing the error – royhowie Jul 07 '15 at 23:13