input.equals("string here") not working

Question

I am new to Java. I'm trying to make a program where the user inputs a country and it returns the current time in that country. I have this code:

public static void main(String[] args) {
    Scanner userInput = new Scanner(System.in);

    System.out.println("Enter a country: ");
    String userCountryInput = userInput.nextLine();

    if (userInput.equals("Philippines")) {
        Date date1 = new Date();
        System.out.println(date1);
    }

    if (userInput.equals("Russia")) {
        TimeZone.setDefault(TimeZone.getTimeZone("UTC + 05:30"));

        Date date2 = new Date();
        System.out.println(date2);
    }
}

When I enter "Russia" or "Philippines" it does not output anything. Any idea why?

asking for books will lead to a discussion, which isn't the aim on this site. In my opinion if Java is the first language, you're learning, you should choose a book in your mothertongue. The most books will cover the basic needs and after you got started, you will learn the most as you need it by reading in forums, apis or solving problems. — Sebastian Walla, Jul 08 '15 at 11:57

Reimeus · Answer 1 · 2015-07-08T11:57:36.580

3

userCountryInput is the input variable. userInput is the Scanner variable used to get the input

if ("Philippines".equals(userCountryInput)) {

edited Jul 08 '15 at 11:57

answered Jul 08 '15 at 11:48

Reimeus

158,255
15
216
276

if (userInput == "Philippines") gives me an error. it says "incomparable types: scanner and string" – Dylan Villaruel Jul 08 '15 at 11:50
that makes no sense - just compare the String returned from `nextLine` with the literal value – Reimeus Jul 08 '15 at 11:52
Okay sorry, I got it. Rookie statement I made right there. Thank you, Reimeus – Dylan Villaruel Jul 08 '15 at 11:53
@DylanVillaruel and why would you use `==` to compare strings when you seem to already know that [you should use `euqlas`](http://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java)? – Pshemo Jul 08 '15 at 11:55
@Pshemo I just knew, like a few minutes ago. I dont have any keen knowledge on the functions yet. – Dylan Villaruel Jul 08 '15 at 12:19

score 0 · Answer 2 · answered Jul 08 '15 at 11:49

You are using equals on userInput wich is the scanner and not the string. It will work on the string userCountryInput :

 public static void main(String[] args) {
    Scanner userInput = new Scanner(System.in);

    System.out.println("Enter a country: ");
    String userCountryInput = userInput.nextLine();

    if (userCountryInput .equals("Philippines")){

        Date date1 = new Date();
        System.out.println(date1);
    }

    if (userCountryInput .equals("Russia")){
        TimeZone.setDefault(TimeZone.getTimeZone("UTC + 05:30"));

        Date date2 = new Date();
        System.out.println(date2);
    }
}

Thank you man! I got it now – Dylan Villaruel Jul 08 '15 at 11:53 — Dylan Villaruel, Jul 08 '15 at 11:53

score 0 · Answer 3 · answered Jul 08 '15 at 12:00

0

As stated by others, you are mixing up the userInput with userCountryInput.

You should use better names for your variables so you don't mix them up again in the future. For example, it might be worth to rename userCountryInput to userCountry.

answered Jul 08 '15 at 12:00

Diyarbakir

1,999
18
36

input.equals("string here") not working

3 Answers3