Syntax error near unexpected token `done' whis done written

Question

I have a problem with the done. It says I have some typo error but I can't figure what's wrong at all. Here is the code:

#./bin/bash
until [$err == 0];
do
    java -Xms512m -Xmx512m -cp lib/*:lib/uMad/*:mysql-connector-java-5.1.15-bin.jar:l2jfrozen-core.jar com.l2jfrozen.gameserver.GameServer
    err=$?
    sleep 5
done

@barma was incorrect. There _is_ an `until` loop in Bash: http://www.gnu.org/software/bash/manual/bash.html#Looping-Constructs — paddy, Jul 13 '15 at 20:47
What version of `bash` are you using? `until` is a recent addition. — Barmar, Jul 13 '15 at 20:47
@paddy That's why I deleted the comment. I was looking at the `bash 3.2` on my Mac, not the 4.x documentation on the web. — Barmar, Jul 13 '15 at 20:48
@Barmar i dont know... how can i get the edition? im using ubuntu btw — Μάνος Σταθόπουλος, Jul 13 '15 at 20:53
@thatotherguy its says everything is ok but i still get the error — Μάνος Σταθόπουλος, Jul 13 '15 at 20:57
@Barmar I am using bash 3.2.53 on my Mac, and it supports `until`. I'm pretty sure the problem is that `#./bin/bash` should read `#!/bin/bash`. — paddy, Jul 13 '15 at 21:01
@ΜάνοςΣταθόπουλος Can you update your question with the code that it says is ok, and also include the error you get? — that other guy, Jul 13 '15 at 21:03
@paddy Never mind, I was looking in the wrong part of the man page. — Barmar, Jul 13 '15 at 21:04
ive done everithing i give up it keeps saying about the unexpected done.. thank each and every one of you for your time! — Μάνος Σταθόπουλος, Jul 13 '15 at 21:13
Umm, did you convert the file to unix line endings, like @Barmar said? This is actually the problem now, as per your most recent comment on my answer. — paddy, Jul 14 '15 at 00:15
@paddy i edited the file using my linux vps using the vi command! — Μάνος Σταθόπουλος, Jul 14 '15 at 20:32
You really shouldn't get in the habit of quitting. Try this: Get all the correct code in a text editor and copy it. In your terminal, type `cat > myscript.sh` and hit Enter, then paste the code in, make sure you're on a new line and press Ctrl-D. This should ensure that you have created a new file without CRLF line endings. Now `chmod +x myscript.sh` and run it. — paddy, Jul 16 '15 at 02:00

paddy · Answer 1 · 2015-07-13T21:04:15.603

2

Your shebang line is wrong. #./bin/bash will not execute bash.

It should read #!/bin/bash. You are probably using a shell other than bash to invoke this script.

Also, beware that the [$err == 0] line expands the value of $err, which is probably an empty string, unless it has been exported. If it's empty, this will result in an error, because Bash will be interpreting [ == 0].

The safest approach is this:

unset err
until [ "$err" == "0" ];
do
    # etc...
done

edited Jul 13 '15 at 21:04

answered Jul 13 '15 at 20:44

paddy

60,864
6
61
103

`#./bin/bash err=1 until [ "$err" == "0"]; do java -Xms512m -Xmx512m -cp lib/*:lib/uMad/*:mysql-connector-java-5.1.15-bin.jar:l2jfrozen-core.jar com.l2jfrozen.gameserver.GameServer err=$? sleep 10 done` still not working :/ – Μάνος Σταθόπουλος Jul 13 '15 at 20:48
@ΜάνοςΣταθόπουλος Why don't you post the actual error message you're getting? – paddy Jul 13 '15 at 20:49
@paddy loop.sh: line 8:syntax error near unexpected token 'done' loop.sh line 8: 'done' – Μάνος Σταθόπουλος Jul 13 '15 at 20:51
@ΜάνοςΣταθόπουλος I have edited my answer, after noticing the first line of your script is wrong. – paddy Jul 13 '15 at 20:53
@paddy its doesnt work like that #!/bin/bash it says /bin/bash^M: bad interpreter: no such file or directory – Μάνος Σταθόπουλος Jul 13 '15 at 21:01
1

That's what you get for editing Unix files on Windows. Use `dos2unix` to fix it. – Barmar Jul 13 '15 at 21:02
@paddy You need a space before `]` – Barmar Jul 13 '15 at 21:03
I don't think Ubuntu comes with `dos2unix` out of the box. Simple option here: http://stackoverflow.com/a/802439/1553090 – paddy Jul 13 '15 at 21:06

score 0 · Answer 2 · answered Jul 13 '15 at 20:57

From my experience when working with brackets and if loops, you need proper spacing and double, not single brackets. There needs to be space on each side of the double brackets with the exception of the semi-colon. Here is an example block:

#!/bin/bash

err=5
until [[ $err == 0 ]]; do
    ((err-=1));
    echo -e "$err\n";
    sleep 3
done

I do not see why the same would not apply to a do until loop.

You're probably aware but your heading has a period in it instead of a shebang.

#./bin/bash

Syntax error near unexpected token `done' whis done written

2 Answers2