ViewBag is not written in output for Razor

Question

ViewBag value is completely ignored while running ASP.NET MVC4 web page.

enter image description here

Here is the source for above image. Even though I am checking if the ViewBag.SearchResultsJson is null or empty, ViewBag still isn't written in the output.

<script>
    @{
        HtmlString jsonText = new HtmlString("");
        if (!string.IsNullOrWhiteSpace(ViewBag.SearchResultsJson))
        {
            jsonText = Html.Raw(ViewBag.SearchResultsJson);
        }
    }

    $(document).ready(function() {
        var json = @jsonText;
        app.value('searchResultsJson', json);
    })
</script>

What am I missing here?

[Don't use ViewBag, use a Viewmodel instead.](http://stackoverflow.com/questions/28696183/how-to-set-and-get-id-of-buttons-created-within-a-loop/28696785#28696785) — Inspector Squirrel, Jul 17 '15 at 13:51
@sippy I am using a ViewModel for getting/setting form data already. Maybe my design for the page is not optimal for this being my first MVC project. — dance2die, Jul 17 '15 at 14:08
Always use a viewmodel property over ViewBag. ViewBag is never necessary and is harder to debug. — Inspector Squirrel, Jul 17 '15 at 14:09

Claudio Redi · Accepted Answer · 2015-07-17T13:50:22.047

1

According your code, an empty jsonText is a valid scenario so I won't focus on why this variable is empty.

The reason for your error is you're not wrapping @jsonText with quotes to render a valid string on Javascript side.

You should change

var json = @jsonText;

by

var json = '@jsonText';

edited Jul 17 '15 at 13:50

answered Jul 17 '15 at 13:37

Claudio Redi

67,454
15
130
155

ViewBag is not written in output for Razor

1 Answers1