java service 400 bad request error

Question

Dear spring Java professionals

please help me out in this : I have a custom service in spring and I dont have any errors on my wildfly server when i run it . but when I do the below update request i am getting 400 bad request though im sending the format as specified in my controller

inside my controller :

@RequestMapping(value = "/user/updatefilters/{Id}", method = RequestMethod.POST)
    public Response updateFilter(@PathVariable("Id") Long Id, @RequestBody @Valid Filter Filter) {

        FilterService.updateFilter(Id, Filter);

        HashMap<String, Object> response = new HashMap<>();
        response.put("messages", null);
        response.put("success", Boolean.valueOf(true));
        return Response.instance().friendlyName("filter-updated").object(response).statusCode(HttpStatus.OK);
}

inside my service file :

public void updateFilter(Long Id,Filter Filter) {
    List<Filter> currentFilter = FilterRepo.getFilters(Id, Filter.getFilterId().longValue(),null);
    currentFilter.get(0).setLabel(Filter.getLabel());
    FilterRepo.save(currentFilter.get(0));

    for (FilterField FilterField : Filter.getFilterFields()) {
        FilterField currentFilterField = FilterFieldRepo.getFilterField(FilterField.getfieldId());
        if (currentFilterField != null) {
            currentFilterField.setfield(FilterField.getfield());
            currentFilterField.setTypeId(FilterField.getTypeId());
            FilterFieldRepo.save(currentFilterField);
        }           
    }   
}

inside my repository :

public List<Filter> getFilterList(Long Id, String type) {
    List<Filter> FilterField = FilterFieldRepo.getFilterFields(Id,type);
    return FilterField;
}   

public void updateFilter(Long Id,Filter Filter) {
    List<Filter> currentFilter = FilterRepo.getFilters(Id, Filter.getFilterId().longValue(),null);
    currentFilter.get(0).setLabel(Filter.getLabel());
    FilterRepo.save(currentFilter.get(0));

    for (FilterField FilterField : Filter.getFilterFields()) {
        FilterField currentFilterField = FilterFieldRepo.getFilterField(FilterField.getfieldId());
        if (currentFilterField != null) {
            currentFilterField.setfield(FilterField.getfield());
            currentFilterField.setTypeId(FilterField.getTypeId());
            FilterFieldRepo.save(currentFilterField);
        }           
    }   
}

Please note that inside my entity I added a transient list like this :

@Transient
private List<FilterField> filterFields;

updated : this is my Filter class i generated the crud in netbeans but added the transuent list manually:

@Entity
@Table(schema="hitmeister",name = "filters")
@NamedQueries({
    @NamedQuery(name = "Filter.findAll", query = "SELECT s FROM Filter s"),
    @NamedQuery(name = "Filter.findByFilterId", query = "SELECT s FROM Filter s WHERE s.filterId = :filterId"),
    @NamedQuery(name = "Filter.findById", query = "SELECT s FROM Filter s WHERE s.Id = :Id"),
    @NamedQuery(name = "Filter.findByLabel", query = "SELECT s FROM Filter s WHERE s.label = :label"),
    @NamedQuery(name = "Filter.findByInsertionDate", query = "SELECT s FROM Filter s WHERE s.insertionDate = :insertionDate"),
    @NamedQuery(name = "Filter.findByIsActive", query = "SELECT s FROM Filter s WHERE s.isActive = :isActive"),
    @NamedQuery(name = "Filter.findByType", query = "SELECT s FROM Filter s WHERE s.type = :type")})
public class Filter implements Serializable {
    private static final long serialVersionUID = 1L;
    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @Basic(optional = false)
    @Column(name = "filter_id")
    private Integer filterId;
    @Basic(optional = false)
    @NotNull
    @Column(name = "id")
    private int Id;
    @Basic(optional = false)
    @NotNull
    @Size(min = 1, max = 500)
    @Column(name = "label")
    private String label;
    @Basic(optional = true)
    @Column(name = "insertion_date")
    @Temporal(TemporalType.TIMESTAMP)
    private Date insertionDate;
    @Column(name = "is_active")
    private Boolean isActive;
    @Basic(optional = false)
    @NotNull
    @Size(min = 1, max = 20)
    @Column(name = "type")
    private String type;

    @Transient
    private List<FilterField> filterFields;

    public Filter() {
    }

    public Filter(Integer filterId) {
        this.filterId = filterId;
    }

    public Filter(Integer filterId, int Id, String label, Date insertionDate, String type) {
        this.filterId = filterId;
        this.Id = Id;
        this.label = label;
        this.insertionDate = insertionDate;
        this.type = type;
    }

    public Integer getFilterId() {
        return filterId;
    }

    public void setFilterId(Integer filterId) {
        this.filterId = filterId;
    }

    public int getId() {
        return Id;
    }

    public void setuserId(int Id) {
        this.userId = userId;
    }

    public String getLabel() {
        return label;
    }

    public void setLabel(String label) {
        this.label = label;
    }

    public Date getInsertionDate() {
        return insertionDate;
    }

    public void setInsertionDate(Date insertionDate) {
        this.insertionDate = insertionDate;
    }

    public Boolean getIsActive() {
        return isActive;
    }

    public void setIsActive(Boolean isActive) {
        this.isActive = isActive;
    }

    public String getType() {
        return type;
    }

    public void setType(String type) {
        this.type = type;
    }
    @Override
    public int hashCode() {
        int hash = 0;
        hash += (filterId != null ? filterId.hashCode() : 0);
        return hash;
    }

    @Override
    public boolean equals(Object object) {
        // TODO: Warning - this method won't work in the case the id fields are not set
        if (!(object instanceof Filter)) {
            return false;
        }
        Filter other = (Filter) object;
        if ((this.filterId == null && other.filterId != null) || (this.filterId != null && !this.filterId.equals(other.filterId))) {
            return false;
        }
        return true;
    }

    @Override
    public String toString() {
        return " Filter #"+ filterId ;
    }

    public List<FilterField> getFilterFields() {
        return filterFields;
    }

    public void setFilterFields(List<FilterField> filterFields) {
        this.filterFields = filterFields;
    }


}

If you need my entity code i can post it as well Thanks In advance !

Answer 1

My first recommendation: (OP tried and it didn't work, she was sending POST request)

Change your mapping as below and I think you should be fine. Request from browser address bar is a GET request.

As you can see below, HTTP 400 comes when server is unable to understand the request client is sending, and in your case you are sending GET but server has nothing for GET but for POST, so 400.

W3C HTTP 400

10.4.1 400 Bad Request

The request could not be understood by the server due to malformed syntax. The client SHOULD NOT repeat the request without modifications.

Code fix:

@RequestMapping(value = "/user/updatefilters/{Id}", method = RequestMethod.GET)

My second recommendation:

I am not Spring expert but here are my 2 cents you can try based on the JSON object you have provided and your Filter mapping - (1.) Change userId to Id, (2.) Have insertionDate as NULL, instead of an empty string.

Make sure your JSON string variables are mapped case-sensitively with your Filter class mapping, and their values are compatible with reference types.

Answer 2

Either your request format is not what Spring expects, or one of the Filter validations is failing. Add a org.springframework.validation.Errors argument and dump the values to find out what validations failed.

public Response updateFilter(@PathVariable("Id") Long Id, @RequestBody @Valid Filter Filter, Errors filterErrors) {

You can sniff the actual traffic using curl or a network monitoring tool to make sure the HTTP transaction is really what you think it is.

EDIT: Having looked at the JSON in one of your comments, I think this is going to turn out to be upper/lower case in your JSON field names. Either change "Id" to "id" and "FilterId" to "filterId", or annotate the Filter fields with @XmlElement(name = "Id") and @XmlElement(name = "FilterId"). Java Bean property names are case sensitive.

EDIT 2: Filter.setuserId(int Id) is broken as well. You need a setId() method for deserializing the bean, and you need to change the method so it stores the passed argument instead of just setting userId to itself.