spring mvc interceptor request scope

Question

I'm developing a web app with Spring 4.1.7 and Hibernate 4.3.10. I needed to create an Interceptor for manage transactions like this:

public class ControllerInterceptor extends HandlerInterceptorAdapter
{

@Autowired
private SessionFactory sessionFactory;

private Session session;

@Override
public boolean preHandle(HttpServletRequest request,
                         HttpServletResponse response,
                         Object handler) throws Exception
{
    super.preHandle(request, response, handler);
    ControllerInterceptor ci = this;
    session = sessionFactory.getCurrentSession();
    //Transaction management....
    return true;
}

@Override
public void afterCompletion(HttpServletRequest request,
                            HttpServletResponse response,
                            Object handler,
                            Exception ex) throws Exception
{
    //Transaction commit/rollback
    if (null != session && session.isOpen())
    {
        try
        {
            session.close();
        }
        catch (Exception e)
        {
            e.printStackTrace();
        }
    }

}
}

In applicationContext.xml I defined the interceptor in this way:

<mvc:interceptors>
    <bean class="com.interceptor.ControllerInterceptor" />
</mvc:interceptors>

My ControllerInterceptor is singleton but I need it in request scope. I tried to define the interceptor in this way:

<mvc:interceptors>
    <bean class="com.interceptor.ControllerInterceptor" scope="request" />
</mvc:interceptors>

but I had this error:

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping#0': Initialization of bean failed; nested exception is java.lang.IllegalStateException: No thread-bound request found: Are you referring to request attributes outside of an actual web request, or processing a request outside of the originally receiving thread? If you are actually operating within a web request and still receive this message, your code is probably running outside of DispatcherServlet/DispatcherPortlet: In this case, use RequestContextListener or RequestContextFilter to expose the current request.

Any suggestion?Thanks

Because I need to put some global variables into the interceptor to write and read them in preHandle and postHandle method — user3363936, Jul 27 '15 at 09:52
It is not an answer to your question - but why do you want to start transaction at before controller method. It is antipattern - Open Session in View. You should limit your to transaction to least actions as possible. — Oleksii Duzhyi, Jul 27 '15 at 10:20
Did you try to use what the error stated : `In this case, use RequestContextListener or RequestContextFilter to expose the current request.` ? — Gyan, Jul 27 '15 at 10:42

score -1 · Answer 1 · edited May 23 '17 at 11:46

-1

MVC interceptors need not have request scope as they are executed for current request only.

To quote from java docs of HandlerInterceptor.preHandle -

Intercept the execution of a handler. Called after HandlerMapping determined an appropriate handler object, but before HandlerAdapter invokes the handler. DispatcherServlet processes a handler in an execution chain, consisting of any number of interceptors, with the handler itself at the end. With this method, each interceptor can decide to abort the execution chain, typically sending a HTTP error or writing a custom response.

Parameters:
request - current HTTP request
response - current HTTP response
handler - chosen handler to execute, for type and/or instance evaluation

Moreover as pointed correctly by Olesksii you need to avoid the anti-pattern of session / transaction management here.

Instead have a look at @Transactional. Suggested reads -> this , this & this

edited May 23 '17 at 11:46

Community

1
1

answered Jul 27 '15 at 10:43

Bond - Java Bond

3,972
6
36
59

Why is it anti-pattern? I just need to manage an unique transaction per request. Can you suggest me a different solution please? – user3363936 Jul 27 '15 at 10:47
I read that @Transactional annotation is not suggested for Controller but only for service... – user3363936 Jul 27 '15 at 12:35
correct - because transaction should be kept as concise as possible. – Bond - Java Bond Jul 28 '15 at 06:48

spring mvc interceptor request scope

1 Answers1