Android app button not getting disabled/unclickable

Question

The button is defined in the mainUI thread Here is the part of my code causing trouble-

        button.setOnClickListener(new OnClickListener() {
        public void onClick(View v){
            new Thread(new Runnable() {

                public void run() {
                    try {
                        OutputStream outToServer = client.getOutputStream();
                        DataOutputStream out = new DataOutputStream(outToServer);
                        out.writeUTF("Hello from " + client.getLocalSocketAddress());
                        final String msg = edi.getText().toString();
                        out.writeUTF("Client: " + msg);

                        runOnUiThread(new Runnable() {
                            @Override
                            public void run() {
                                tex.append(msg);
                                if (msg == "quit") {
                                    button.setClickable(false);
                                    tex.append("quitbutton");
                                }
                                tex.append("Client: " + msg + "\n");
                                edi.setText("");
                            }
                        });

                    } catch (Exception e) {
                        e.printStackTrace();
                    }
                }}).start();
        }
    });

Rest of the code here is working perfectly fine. When I send in "quit" as string, the msg variable has it correctly. Problem seems not to be entering the if block at all, because if it did, it should have shown "quibutton" text in the textview, which it ain't.

I'd appreciate any kind of help, thanks :)

Edit- I didn't realize that I wasn't comparing the strings in the right way, not that I don't know how to. It probably got mixed up with C++ operator overloaded function in my head that I wanted to compare strings using == directly.

instead of `msg == "quit"` use `msg.equals("quit");` – Blackbelt Jul 27 '15 at 12:33 — Blackbelt, Jul 27 '15 at 12:33
Oh crap, yes you are right! My bad! – Akash Agarwal Jul 27 '15 at 12:33 — Akash Agarwal, Jul 27 '15 at 12:33

Rishad Appat · Accepted Answer · 2015-07-27T12:42:02.827

0

change this

if (msg == "quit") {
                    button.setClickable(false);
                    tex.append("quitbutton");
                   }

to this

if (msg.equals("quit")) {
                    button.setEnabled(false);
                    tex.append("quitbutton");
                   }

edited Jul 27 '15 at 12:42

answered Jul 27 '15 at 12:34

Rishad Appat

1,786
1
15
30

Yes you are right, so dumb I forgot the correct way to compare strings. – Akash Agarwal Jul 27 '15 at 12:35
Please accpt the answr if it works,,, – Rishad Appat Jul 27 '15 at 12:36
Yes i will as soon as it allows me, in 7 minutes. – Akash Agarwal Jul 27 '15 at 12:40
`msg.Equals("quit")` ? – Blackbelt Jul 27 '15 at 12:41
@Blackbelt please check my editted message in the main post :) – Akash Agarwal Jul 27 '15 at 12:47

Android app button not getting disabled/unclickable

1 Answers1