Angular promises - odd behaviour

Question

I have and angular module angular.validators that is a wrapper for validator.js. Up until now every time validator.js was updated I would copy the source code and paste it on my service and then make it available on my directives.

I decided to automate the procedure and replaced the service code with the following:

.service('validator', ['$http', '$q', 'validator_version', function ($http, $q, version) {
    var deferred = $q.defer();
    $http.get('https://cdn.rawgit.com/chriso/validator.js/'+ version + '/validator.js')
        .then(function(result){
            deferred.resolve(result.data);
        });
    return deferred.promise;
}])

I know that it should not work, because validator returns a promise and on my directives I treat it like a regular function, e.g:

.directive('contains', ['validator', function (validator) {
    return {
        require: 'ngModel',
        restrict: 'A',
        link: function (scope, element, attrs, controller) {
            controller.$validators.contains = function (modelValue, viewValue) {
                if (controller.$isEmpty(modelValue)) {
                    return true;
                }
                return validator.contains(viewValue, attrs.contains);
            };
        }
    };
}])

but when i run my karma tests, oddly all tests pass without issues (a total of 81 tests atm). I thought that this is odd and then created a test project for my module and indeed when I ran it live on the browser all directives failed since they were not available. Why could this behaviour be?

Update: I've moved the odd code to a new branch, here.

Your first code is the deferred (explicit construction) antipattern. http://stackoverflow.com/questions/23803743/what-is-the-explicit-promise-construction-antipattern-and-how-do-i-avoid-it — Benjamin Gruenbaum, Aug 09 '15 at 12:25
I know I could just return the http.get but the heart of the question is why my tests pass and when live it doesn't work — gkaimakas, Aug 09 '15 at 12:28
I have no idea, it's very hard to reproduce given the current data. — Benjamin Gruenbaum, Aug 09 '15 at 12:29
You can find the tests on the github page. That's why I posted the repo :). I went back to the older implementation for the service, now called node validator, but you can change it to see what happens. — gkaimakas, Aug 09 '15 at 12:32
I've added a new branch with that odd behaviour. You can find it here https://github.com/gkaimakas/angular.validators/tree/asyncLoading — gkaimakas, Aug 09 '15 at 12:57

Angular promises - odd behaviour

0 Answers0