Why is my str.replace line not working?

Question

I'm making a function that takes a string, cuts the first half (leaving middle character if odd string.length) and adds first half to end of string.

For some reason my function only partlyworks: it adds the substr to the end but doesn't cut it from the start. I tried .replace but not working.

What am I doing wrong? And/or is there a better way?

You've got `'substr'` as the first argument to `.replace()` - the **string** `'substr'`, not the variable. — Pointy, Aug 09 '15 at 14:03
Or to put it another way: Don't post code as a picture, post it as *code*. — T.J. Crowder, Aug 09 '15 at 14:06
If it weren't for the `'substr'` thing, this would be a duplicate of http://stackoverflow.com/questions/21162097/node-js-string-replace-doesnt-work (and many, many others). — T.J. Crowder, Aug 09 '15 at 14:06
just posted it as an img out of bad habit and <3 for colours in code — Tam Borine, Aug 09 '15 at 14:15

score 2 · Accepted Answer · edited May 23 '17 at 12:32

2

replace returns a new string with the replacement, it doesn't modify the string you call it on.

Additionally, as Pointy pointed out, you've passed the literal string 'substr' in, rather than passing in the variable substr.

So:

s = s.replace(substr, '');

edited May 23 '17 at 12:32

Community

1
1

answered Aug 09 '15 at 14:04

T.J. Crowder

1,031,962
187
1,923
1,875

score 0 · Answer 2 · answered Aug 09 '15 at 14:21

a friend just gave another way to write a function that does what I wanted mine to do . I'm an amoeba and you're all wizards

function doit(s){
split = s.length /2;

if(split % 2 !== 0) { split = split-1; }
var partOne = s.slice(0, split);
var partTwo = s.slice(split + 1, s.length);

return partTwo + partOne;

}



alert(doit('123456789qwertyuio'));

Why is my str.replace line not working?

2 Answers2