populate listview fragment tab android

Question

My problem here is that my listview doesn't show when the activity loads.

Here is my activity code :

protected void onCreate(Bundle savedInstanceState) {
...
 TabLayout tabLayout = (TabLayout) findViewById(R.id.tab_layout);
        tabLayout.addTab(tabLayout.newTab().setText("A"));
        tabLayout.addTab(tabLayout.newTab().setText("B"));
        tabLayout.addTab(tabLayout.newTab().setText("C"));
        tabLayout.setTabGravity(TabLayout.GRAVITY_FILL);

        getServices();

        final ViewPager viewPager = (ViewPager)       findViewById(R.id.pager);
        final PagerAdapter adapter = new PagerAdapter
                (getSupportFragmentManager(), tabLayout.getTabCount());
        viewPager.setAdapter(adapter);
        adapter.notifyDataSetChanged();
        viewPager.addOnPageChangeListener(new        TabLayout.TabLayoutOnPageChangeListener(tabLayout));

        tabLayout.setOnTabSelectedListener(new TabLayout.OnTabSelectedListener() {
            @Override
            public void onTabSelected(TabLayout.Tab tab) {
                viewPager.setCurrentItem(tab.getPosition());
            }

            @Override
            public void onTabUnselected(TabLayout.Tab tab) {

            }

            @Override
            public void onTabReselected(TabLayout.Tab tab) {

            }
        });
        adapter.notifyDataSetChanged();
  }





   public void getServices(){
    RequestQueue queue;
    queue = Volley.newRequestQueue(this);


    String url = "http://..."

    JsonArrayRequest jsonArrayRequest = new JsonArrayRequest(Request.Method.GET,url,
            new Response.Listener<JSONArray>() {
                @Override
                public void onResponse(JSONArray response) {
                    for(int i=0;i<response.length();i++){
                        try{

                            JSONObject jsonObjectService =        response.getJSONObject(i);
                            Service service = new Service(jsonObjectService);
                            serviceList.add(service);
                        }
                        catch(JSONException e){
                            e.printStackTrace();
                        }
                    }
                }
            }, new Response.ErrorListener() {
        @Override
        public void onErrorResponse(VolleyError error) {

        }
    });

    queue.add(jsonArrayRequest);
}

And here my fragment :

 @Override
  public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {

    v = inflater.inflate(R.layout.fragment_tab_fragment1, container, false);

    activity = (SalonInformationsActivity) getActivity();
    listView = (ListView) v.findViewById(R.id.list_service);
    serviceList = activity.getServiceList();
    adapter = new ServiceListAdapter(activity, serviceList);
    listView.setAdapter(adapter);
    adapter.notifyDataSetChanged();
    activity.runOnUiThread(new Runnable() {
        @Override
        public void run() {
            adapter.notifyDataSetChanged();
        }
    });

    listView.setOnItemClickListener(new AdapterView.OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> arg0, View arg1, int position, long arg3) {
            ((SalonInformationsActivity)getActivity()).callSalon(v.findFocus());
            //Toast.makeText(getApplicationContext(), salonArrayList.get(position).getTel(), Toast.LENGTH_SHORT).show();
        }
    });
    return v;
}

I'm new to android and i don't know why the listview doesn't show. But if i clic on other tab then return to the tabA the listview appears with my listview updated. Any solution to get the listview fill when it starts ?

Narendra Kothamire · Accepted Answer · 2015-08-13T08:46:24.983

0

Your network call is taking time to return data that you add to your arraylist perform that network call in fragment instead of activity and once it is added to arraylist perform notifyDataSetChanged() on adapter

In your current case fragment is getting created before newtwork data is returned so that arraylist size is 0

and there is no need of this

 activity.runOnUiThread(new Runnable() {
        @Override
        public void run() {
            adapter.notifyDataSetChanged();
        }
    });

you can simply call adapter.notifyDataSetChanged();

edited Aug 13 '15 at 08:46

answered Aug 13 '15 at 08:43

Narendra Kothamire

973
5
11

You mean that i should put a notifyDataSetChanged in my method ? – Sambo Aug 13 '15 at 08:46
yes if you don't want to change code then create a public method in fragment that will perform adapter.notifyDataSetChanged() and call that method after you add data to arraylist in the network success call – Narendra Kothamire Aug 13 '15 at 08:52
I tried to add a method in my fragment refreshListView() with adapter.notifyDataSetChanged() in call it in my success response but i have an error null object reference on my adapter – Sambo Aug 13 '15 at 09:27
JSONObject jsonObjectService = response.getJSONObject(i); Service service = new Service(jsonObjectService); serviceList.add(service); TabFragment1 fragment = (TabFragment1) getSupportFragmentManager().findFragmentById(R.id.tab_layout); fragment.refreshListView(); – Sambo Aug 13 '15 at 09:33
public void refreshListView(){ adapter.notifyDataSetChanged(); } – Sambo Aug 13 '15 at 09:34
Well, i guess it's because i can't find my TabFragment1 id – Sambo Aug 13 '15 at 09:35
Perform your network call in fragment instead of activity – Narendra Kothamire Aug 13 '15 at 09:37
But my fragment has no id :( – Sambo Aug 13 '15 at 09:37
Oh your trying to find fragment by Id, is your fragment is in viewpager – Narendra Kothamire Aug 13 '15 at 09:38
Yes, in viewpager and in a tablayout – Sambo Aug 13 '15 at 09:40
Ok do this to get required fragment http://stackoverflow.com/questions/8785221/retrieve-a-fragment-from-a-viewpager – Narendra Kothamire Aug 13 '15 at 09:41
Sorry to bother you again but how do i accept ?Nevermind, i found the tick on the left – Sambo Aug 13 '15 at 10:07

populate listview fragment tab android

1 Answers1