Whats wrong with my query?

Question

Can anyone see any errors in this code? I've checked to make sure the data has been written to the database. Every time I click the button it gives me the "Incorrect Password" text. It's probably something stupid that I'm overlooking. Any help is appreciated.

public void buttonWork() {
    button_credCheck.setOnClickListener(new View.OnClickListener() {
        String rpq = regPwdQuery().toString();
        String passInputStr = editText_pwdInput.getText().toString();

        @Override
        public void onClick(View v) {
            if (passInputStr == rpq) {
                Intent myIntent = new Intent(LogInActivity.this, FindInfoActivity.class);
                startActivity(myIntent);

            } else {
                Toast.makeText(LogInActivity.this, "Incorrect Password", Toast.LENGTH_LONG).show();
            }
        }
    });
}

EDIT: This is not a duplicate of the referenced question because changing == to equals() did not fix my problem.

EDIT 2: Thought maybe I should Include the cursor class for regPwdQuery

 public Cursor regPwdQuery() {
        String regPwdData = editText_pwdInput.getText().toString();
        String regQuery = "SELECT * FROM UsrPass_table WHERE Pwrd ='" +   regPwdData + "'";
        SQLiteDatabase uDB = usrDB.getReadableDatabase();
        Cursor result = uDB.rawQuery(regQuery, null);
        return result;

Answer 1

The == operator is used when we have to compare the String object references. If two String variables point to the same object in memory, the comparison returns true.

The equals method is used when we need to compare the content of the text present in the String objects. This method returns true when two String objects hold the same content (i.e. the same values).

To compare two strings for equality, use equals( ).

public void buttonWork() {
    button_credCheck.setOnClickListener(new View.OnClickListener() {
        String rpq = regPwdQuery().toString();
        String passInputStr = editText_pwdInput.getText().toString();

        @Override
        public void onClick(View v) {
           if (passInputStr.equals(rpq))
                Intent myIntent = new Intent(LogInActivity.this, FindInfoActivity.class);
                startActivity(myIntent);

            } else {
                Toast.makeText(LogInActivity.this, "Incorrect Password", Toast.LENGTH_LONG).show();
            }
        }
    });
}

Answer 2

You can not compare Strings in java with == operator. Use equals() method instead:

if (passInputStr.equals(rpq))

Answer 3

That essentially means passInputStr != rpq , You could try the .equalsIgnoreCase() method or the .equals() method. That is because you are comparing strings! You can read more about this here

Answer 4

your comparisons checks the refferences instead the actual content of the strings. Instead use .equals() to check the value of the String.

if (passInputStr == rpq)

Should be changed to:

if(passInputStr.equals(rpq))

EDIT:

you toString the result you get from the query:

String rpq = regPwdQuery().toString();

if your result only contains the password it might work, but otherwise I don't think it will give the correct result. Since I don't know how the table UsrPass_table looks like I can only guess but I think something like this has to be implemented:

public String regPwdQuery() { String regPwdData = editText_pwdInput.getText().toString(); String regQuery = "SELECT * FROM UsrPass_table WHERE Pwrd ='" + regPwdData + "'"; SQLiteDatabase uDB = usrDB.getReadableDatabase(); Cursor result = uDB.rawQuery(regQuery, null); String password = ""; while(result.moveToNext()){ password = result.getString(0); //Parameter should match the column from where you get your data, normally 0 is an ID. } return password;

Hope it helps.

Answer 5

Try the

 if (passInputStr.equals(rpq))

reference:

What is the difference between == vs equals() in Java?

Here is an example (you can run it):

public final class MyEqualityTest
{
    public static void main( String args[] )
    {
        String s1 = new String( "Test" );
        String s2 = new String( "Test" );

        System.out.println( "\n1 - PRIMITIVES ");
        System.out.println( s1 == s2 ); // false
        System.out.println( s1.equals( s2 )); // true

        A a1 = new A();
        A a2 = new A();

        System.out.println( "\n2 - OBJECT TYPES / STATIC VARIABLE" );
        System.out.println( a1 == a2 ); // false
        System.out.println( a1.s == a2.s ); // true
        System.out.println( a1.s.equals( a2.s ) ); // true

        B b1 = new B();
        B b2 = new B();

        System.out.println( "\n3 - OBJECT TYPES / NON-STATIC VARIABLE" );
        System.out.println( b1 == b2 ); // false
        System.out.println( b1.getS() == b2.getS() ); // false
        System.out.println( b1.getS().equals( b2.getS() ) ); // true
    }
}

final class A
{
    // static
    public static String s;
    A()
    {
        this.s = new String( "aTest" );
    }
}

final class B
{
    private String s;
    B()
    {
        this.s = new String( "aTest" );
    }

    public String getS()
    {
        return s;
    }

}

Answer 6

    public void buttonWork() {
    button_credCheck.setOnClickListener(new View.OnClickListener() {


        @Override
        public void onClick(View v) {
        String rpq = regPwdQuery().toString();
        String passInputStr = editText_pwdInput.getText().toString();
            if (passInputStr == rpq) {
                Intent myIntent = new Intent(LogInActivity.this, FindInfoActivity.class);
                startActivity(myIntent);

            } else {
                Toast.makeText(LogInActivity.this, "Incorrect Password", Toast.LENGTH_LONG).show();
            }
        }
    });
}

Try this.. Put rpq and passInputStr in onClick method. also change if condition if (passInputStr.equals(rpq))

Answer 7

Simply, replace:

if (passInputStr == rpq)

with

if (passInputStr.equals(rpq))

Use string.equals(anotherString) method when you want to compare between two different strings.

Edit:

public String regPwdQuery() {
    String regPwdData = editText_pwdInput.getText().toString();
    String regQuery = "SELECT * FROM UsrPass_table WHERE Pwrd ='" + regPwdData + "'";
    SQLiteDatabase uDB = usrDB.getReadableDatabase();
    Cursor cursor = uDB.rawQuery(regQuery, null);
    //Modify this
    String result = cursor.getString(cursor.getColumnIndex("password"));
    return result;