Getting Values from User

Question

hello please i am having issues getting the values of a system generated variables. here is the code for the getting the values from user;

public void DetailsRate()
{
 begin1:
        Console.WriteLine("\n \t Rate the Acting on a scale of 0 to 5");
        RateActing = int.Parse(Console.ReadLine());
        switch (RateActing)
        {
            case 0:
            case 1:
            case 2:
            case 3:
            case 4:
            case 5:
                Console.WriteLine("\n you have rated the action of the movie {0}", RateActing);
                break;
            default:
                Console.WriteLine("you have selected the wrong choice {0}", RateActing);
                goto begin1;
        }

        begin2:
        Console.WriteLine("\n \t Rate the music of the movie on a scale of 0 to 5");
        RateMusic = int.Parse(Console.ReadLine());
        switch (RateMusic)
        {
            case 0:
            case 1:
            case 2:
            case 3:
            case 4:
            case 5:
                Console.WriteLine("you have rated the music of the movie {0}", RateMusic);
                break;
            default:
                Console.WriteLine("you have selected the wrong choice {0}", RateMusic);
                goto begin2;
        }
}

I called the inputed values into this piece of code

public double getoverallRate(double rateact, double ratemus)
    {
        double totrate = 0;

         rateact = RateActing * 0.25;
         ratemus = RateMusic * 0.15;


        totrate = (rateact + ratemus);
        return totrate;
    }

and here is the main method

static void Main(string[] args)
    {

        MovieRating MR = new MovieRating();
        MR.DetailsRate();

        MovieRating MT = new MovieRating();
        double totrate = MT.getoverallRate(1, 2);
        Console.WriteLine("total rate is {0}", totrate);

        Console.ReadKey();
    }

Please what Im i missing the value of totrate is just giving me 0. please help me.

Answer 1

First get rid of the goto statements. At a quick glance you could write this:

    static void Main(string[] args)
    {
        double RateActing = -1;
        double RateMusic = -1;

        RateActing = GetMovieRating(RateActing);

        RateMusic = GetMovieMusicRating(RateMusic);

        double totrate = getoverallRate(RateActing, RateMusic);

        Console.WriteLine("total rate is {0}", totrate);

        Console.ReadKey();
    }

    private static double GetMovieRating(double RateActing)
    {
        do
        {
            Console.WriteLine("\n \t Rate the Acting on a scale of 0 to 5");
            double.TryParse(Console.ReadLine(), out RateActing);
        }
        while (RateActing < 0 || RateActing > 5);
        Console.WriteLine("\n you have rated the action of the movie {0}", RateActing);
        return RateActing;
    }

    private static double GetMovieMusicRating(double RateMusic)
    {
        do
        {
            Console.WriteLine("\n \t Rate the music of the movie on a scale of 0 to 5");
            double.TryParse(Console.ReadLine(), out RateMusic);
        }
        while (RateMusic < 0 || RateMusic > 5);
        Console.WriteLine("\n you have rated the music of the movie {0}", RateMusic);
        return RateMusic;
    }

    public static double getoverallRate(double rateact, double ratemus)
    {
        rateact *= 0.25;
        ratemus *= 0.15;

        return rateact + ratemus;
    }

Answer 2

There are lots of problems here - almost enough to start over!

First: Never use goto - there are better ways to construct your program flow.

Second: Your method getoverallRate takes less parameters (2) than what you're passing in (5) so this shouldn't even build.

Third: You are referencing three additional variables in getoverallRate that look like they should be local variables but they are not defined anywhere. Should these be passed in like the usage implies in Main.

Fourth: you are passing in values in variables rateact and ratemus but you are overwriting them immediately with your calculations.

Fifth: It would make more sense to me if you were passing in the input values from the user to this method along with any others you need. You should not be using Global variables from user input in any method that calculates values and returns a result. You should always pass in whatever is needed by the calculation.

Sixth: What is the point of the MR declaration and what does DetailsRate do?