Clean code which version is correct?

Question

When the only code in there is for a class how would you code it adding public to the default class like so

namespace HW2_2_Spaceship
{
   public class Spaceship //added public to the default class 
    {
      static void Main(string[] args)
        {
        }

or

namespace HW2_1_Book
{
    class Book
    {
        static void Main(string[] args)
        {

        }
        public class Book // added a new class with in the default class
        {

Does the HW in HW2 stand for homework? :) – James Gaunt Jul 11 '10 at 14:46 — James Gaunt, Jul 11 '10 at 14:46
Yes it does, just trying to get it right – Michael Quiles Jul 11 '10 at 14:47 — Michael Quiles, Jul 11 '10 at 14:47

score 6 · Accepted Answer · edited May 23 '17 at 11:57

6

In general, each class should have their own file.

Main should be in Program.cs

There are usecases where you can use Inner classes, see Using Inner classes in C#.

edited May 23 '17 at 11:57

Community

1
1

answered Jul 11 '10 at 14:44

Filip Ekberg

36,033
20
126
183

@Micheal: an external being (the CLR) needs to be able to find your default class to start your program. Therefore, due the need to external accessibility, it should be a public class. – Vitor Py Jul 11 '10 at 14:52
1

@Vitor, The class that has `Main` is per automatic declared public even if you do not write anything in front of it. You can't even declare it private. – Filip Ekberg Jul 11 '10 at 14:57

score 0 · Answer 2 · answered Jul 11 '10 at 15:10

0

//Program.cs, if u use visual studio then ensure you add
// the public access modifier yourself

namespace HW2_2_Spaceship
{
   public class Program
   {
      public static void Main(string[] args)
      {
        //Do something here
      }
   }
}

//Book.cs, add the public modifier to the class
namespace HW2_2_Spaceship
{
  public class Book
  {
   //add method and properties here
  }
}

answered Jul 11 '10 at 15:10

Blessy Antony

113
1
1
5

1

You don't need to add the public modifier on the class that has `Main` in fact it will always be public, you cannot set it to private / protected. – Filip Ekberg Jul 11 '10 at 15:13
I prefer access modifiers to be specified explicitly. – Blessy Antony Jul 11 '10 at 17:29

Clean code which version is correct?

2 Answers2