onClick method delays the main thread

Question

I am making a calculator app in Android that is doing a lot calculation in the onClick method causing it to skip frames:

 I/Choreographer﹕ Skipped 206 frames!  The application may be doing too much work on its main thread.

The method looks like this:

public void onClick(View v) {
    switch (v.getId()) {
        case R.id.btnZero:
        //do some stuff
        break; ...
}

My question is: Can I make this run faster in any way - maybe by some threads or anything else?

206 frames only to the pressure of a button? it's strange..put the code inside btnZero — Michele Lacorte, Sep 03 '15 at 11:34
Make calculations in AsyncTask, disabling button after click and showing progressbar, then after calculation hide progressbar and enable button again. — Mateusz Jablonski, Sep 03 '15 at 11:35

score 3 · Answer 1 · answered Sep 03 '15 at 11:35

You can use a Background-Thread like AsyncTask<...,...,...> to do the calculations and then return the result to you UI. This way the calculations arent done on the MainUI-Thread but in the Background. This way your UI wont freeze and its the common way in Android to do longer activities. See http://developer.android.com/reference/android/os/AsyncTask.html for Reference

score 1 · Answer 2 · edited May 23 '17 at 11:58

1

This appears when you put too much code in the main thread and it is taking time to process so frames are being skipped because of it.

Find the solution here:

The application may be doing too much work on its main thread

edited May 23 '17 at 11:58

Community

1
1

answered Sep 03 '15 at 11:39

Vinay Pandravada

88
14

onClick method delays the main thread

2 Answers2