Unable to compare the JSON String Response in the “if” Statement in android using volley library

Question

I am getting JSON String Response in a string variable. I want to compare it in the “if” statement. But program cannot go to the “if” statement. But it shows the response in the TextView.

Here is my if statement

  if (myObjAsString == "WRONG_PASS_ERROR") { //USER_EXISTS_ERROR //WRONG_PASS_ERROR

                                Toast.makeText(MainActivity.this, "Login Invalid", Toast.LENGTH_LONG).show();
                            }

Here is my code.

String url = "http://someexample.com/signin.php";
        StringRequest postRequest = new StringRequest(Request.Method.POST, url,
                new Response.Listener<String>() {
                    @Override
                    public void onResponse(String response) {
                        try {


                            JSONObject jsonResponse = new JSONObject(response);
                            String myObjAsString = jsonResponse.getString("type");

                            if (myObjAsString == "WRONG_PASS_ERROR") { //USER_EXISTS_ERROR //WRONG_PASS_ERROR

                                Toast.makeText(MainActivity.this, "Login Invalid", Toast.LENGTH_LONG).show();
                            }

                            mTV.setText(myObjAsString);

                        } catch (JSONException e) {
                            e.printStackTrace();
                        }
                    }
                },
                new Response.ErrorListener() {
                    @Override
                    public void onErrorResponse(VolleyError error) {
                        error.printStackTrace();
                    }
                }
        ) {
            @Override
            protected Map<String, String> getParams() {
                Map<String, String> params = new HashMap<>();
                // the POST parameters:
                params.put("email", "example@outlook.com");
                params.put("password", "*****");
                return params;
            }
        };
        Volley.newRequestQueue(this).add(postRequest);

use `.equals("WRONG_PASS_ERROR")` to compare strings. `==` cannot be used. — Breavyn, Sep 08 '15 at 11:16
@ρяσѕρєяK how can i edit this question, that is duplicated with another question. — hasnain_ahmad, Sep 08 '15 at 11:21
@hasnain_ahmad: now you can edit it if u have any other issue but if u have only `compare strings` issues then it is duplicate — ρяσѕρєя K, Sep 08 '15 at 11:22
@ρяσѕρєяK Ok. i have not another issue. But i searched i can't find the question or solution, hence i posted the question. — hasnain_ahmad, Sep 08 '15 at 11:24

score 1 · Accepted Answer · answered Sep 08 '15 at 11:16

1

Use equals. Objects comparison is done like this in java.

if (myObjAsString.equals("WRONG_PASS_ERROR"))

or even this will protect from npe:

if ("WRONG_PASS_ERROR".equals(myObjAsString))

answered Sep 08 '15 at 11:16

MightySeal

2,293
2
17
32

score 0 · Answer 2 · answered Sep 08 '15 at 11:16

0

For comparing strings you do not use the "==" operator, instead you use equals() method. For eg: if(string1.equals(string2))

answered Sep 08 '15 at 11:16

Kaveesh Kanwal

1,753
17
16

score 0 · Answer 3 · answered Sep 08 '15 at 11:16

0

Use below code.

if (myObjAsString.equals("WRONG_PASS_ERROR")) // Change this condition
{ 
      Toast.makeText(MainActivity.this, "Login Invalid", Toast.LENGTH_LONG).show();
}

answered Sep 08 '15 at 11:16

Sagar Zala

4,854
9
34
62

Unable to compare the JSON String Response in the “if” Statement in android using volley library

3 Answers3