Passing parameters to promise's success callback in angularjs $q

Question

I realize this is a very similar question to this one. But I'm still unclear on how to do it in my situation. Just need some help with a successful callback.

This is what works:

function getStuff(accountNumber) {
    var logMessage = 'POST GetStuff';

    return $http.post(GetStuff, { custId: accountNumber })
        .then(log);
}

function log(response) {
    logger.debug(response);
    return response;
}

This is what I want to accomplish:

function getStuff(accountNumber) {
    var logMessage = 'POST GetStuff';

    return $http.post(GetStuff, { custId: accountNumber })
        .then(log(response, logMessage);
}

function log(response, logMessage) {
    logger.debug(logMessage, response);
    return response;
}

score 8 · Accepted Answer · answered Sep 08 '15 at 18:58

8

You can use this:

function getStuff(accountNumber) {
    var logMessage = 'POST GetStuff';

    return $http.post(GetStuff, { custId: accountNumber })
        .then(
           function success(response) {
               return log(response, logMessage);
           }
        );
}

answered Sep 08 '15 at 18:58

Rohit Jain

209,639
45
409
525

Thanks @Rohit, I will use this. It makes the most sense. – Richard.Davenport Sep 08 '15 at 19:10

score 5 · Answer 2 · answered Sep 08 '15 at 18:59

5

Depending on your preference/requirements you could do a few things. I normally write promise callbacks like this, so you could do:

.then(function success(response){
  return log(response, logMessage);
});

or, depending on how you feel about this way (i know some people don't like it, i try to avoid unless absoluley nessesary)

.then(log.bind(null, response, logMessage));

Do either of these work for you?

answered Sep 08 '15 at 18:59

Shan Robertson

2,742
3
25
43

Thanks @Shan, Rohit answered first and the same as your first suggestion, so I took his answer. I couldn't get bind to work and it does look funny, but your first suggestion is good. – Richard.Davenport Sep 08 '15 at 19:11

score 0 · Answer 3 · answered Sep 08 '15 at 19:07

0

See if it can help you:

function getStuff(accountNumber) {
  var logMessage = 'POST GetStuff';
  var deferred = $q.defer();

  return $http.post(GetStuff, { custId: accountNumber })
   .success(function(response){
      deferred.resolve(response);
      log(response, logMessage);
   }).error(function(){
      deferred.reject();
   })     
   return deferred.promise;
}

answered Sep 08 '15 at 19:07

Ali Adravi

21,707
9
87
85

Thanks @Ali, just trying to use the then method. – Richard.Davenport Sep 08 '15 at 19:12
BTW, `success` and `error` methods are deprecated in favour of `then()` method. – Rohit Jain Sep 08 '15 at 19:13
thanks for remind but it is for jQuery and not for jqlite which Angular is using internally, see this https://groups.google.com/forum/#!topic/angular/ixmLu9NPm8k – Ali Adravi Sep 08 '15 at 20:00

Passing parameters to promise's success callback in angularjs $q

3 Answers3

Linked