Printing an array in Java method

Question

So I need to print an array of integers into a String, and I have it almost right with one problem

public static String arrayToString(int[] anArray) {
    String x = "";
    String y = "";
    String result = "";
    for (int i = 0; i < anArray.length; i++) {
        y = Integer.toString(anArray[i]);
        x = x + ", " + y;
    }
    result = "[" + x + "]";
    return result;
}

public static void main(String[] args) {
    int arrayInt[] = new int[] { 80, 100, 80, 92, 95, 87, 82, 76, 45, 76, 80, 70};
    System.out.println("array : " + arrayToString(arrayInt));
}

When I execute the code, instead of printing:

[80, 100, 80, 92, 95, 87, 82, 76, 45, 76, 80, 70]

I get:

[, 80, 100, 80, 92, 95, 87, 82, 76, 45, 76, 80, 70]

This should be really simple to me but I'm stuck, where do I need to put an exception to remove it?

Describe your printing logic with words. What happens to the first element? — Sotirios Delimanolis, Sep 09 '15 at 17:18
Also don't concatenate strings in loop. Use `StrinbBuilder` instead http://stackoverflow.com/a/4645155/1393766 — Pshemo, Sep 09 '15 at 17:25
http://stackoverflow.com/questions/409784/whats-the-simplest-way-to-print-a-java-array — Sotirios Delimanolis, Sep 09 '15 at 17:26

score 0 · Answer 1 · edited May 23 '17 at 10:29

0

You are just adding an extra , in the beginning. One simple way to get rid of it is,
Replace

result = "[" + x + "]";

with

result = "[" + x.substring(1) + "]";

But the best solution would be to use Arrays.toString. See this for more details.

edited May 23 '17 at 10:29

Community

1
1

answered Sep 09 '15 at 17:25

Ghazanfar

1,419
13
21

burglarhobbit · Answer 2 · 2015-09-09T17:45:34.003

The problem is that you are getting an extra comma , at the beginning. This will solve your problem in the arrayToString function:

public static String arrayToString(int[] anArray) {
    String x = "";
    String y = "";
    String result = "";
    for (int i = 0; i < anArray.length-1; i++) {
        y = Integer.toString(anArray[i]);
        x = x + y + ",";
    }
    y = Integer.toString(anArray[anArray.length-1]);
    x = x + y;
    result = "[" + x + "]";
    return result;
}

score 0 · Answer 3 · answered Sep 09 '15 at 17:30

 public static String arrayToString(int[] anArray) {
    String x = "";
    String y = "";
    String result = "";
    for (int i = 0; i < anArray.length; i++) {
        y = Integer.toString(anArray[i]);
        if(x.isEmpty()){
            x = y;
        } else {
            x = x + ", " + y;
        }
    }
    result = "[" + x + "]";
    return result;
}

public static void main(String[] args) {
    int arrayInt[] = new int[] { 80, 100, 80, 92, 95, 87, 82, 76, 45, 76, 80, 70 };
    System.out.println("array : " + arrayToString(arrayInt));
}

score 0 · Answer 4 · answered Sep 09 '15 at 18:05

0

You can include check for first element.

if( i == 0 ) x = y; else x = x + ", " + y;

answered Sep 09 '15 at 18:05

Harshit

692
10
17

Vasu · Answer 5 · 2015-09-09T17:23:37.647

-1

Please change the last line in your code, result string variable as below:

public static String arrayToString(int[] anArray) {
String x = "";
String y = "";
String result = "";
for (int i = 0; i < anArray.length; i++) {
    y = Integer.toString(anArray[i]);
    x = x + ", " + y;
}
 result = "[" + x + "]";
 return result.charAt(0)+result.substring(3);
}

edited Sep 09 '15 at 17:23

answered Sep 09 '15 at 17:18

Vasu

21,832
11
51
67

1

Thank you! I knew I had to use a java method but wasn't sure how to execute them – Alex S Sep 09 '15 at 17:25

Printing an array in Java method

5 Answers5