how to fix divide by zero in android

Question

it is not WORKING !!

I have used different methods to solve the case but did not work

Anyone who can help me?

..............................................................................

           case '/':

                    pp = Double.parseDouble(text.getText().toString());


                    if (sss == '/') {
                        if (Double.parseDouble(text.getText().toString()) == 0.0 ||Integer.parseInt(text.getText().toString()) == 0) {

                            text.setText("");
                            text2.setText("");
                            Toast.makeText(getBaseContext(), "Cannot divide by zero", Toast.LENGTH_SHORT).show();

                        } else if (pp != 0 || pp != 0.0) {

                            vis = tt / pp;

                            temp = (int) vis;
                            if (vis == temp) {

                                text.setText(Integer.toString(temp));
                            } else {

                                text.setText(Double.toString(vis));
                            }

                            vis = 0;
                            ash = 0;
                            break;

                        }
                    }

As a side issue, `temp = (int) vis; if (vis == temp) {} ...` comparing float and int for exact match is fragile. You should be checking if they are close enough instead. See http://stackoverflow.com/questions/1161199/is-relational-comparison-between-int-and-float-directly-possible-in-c — headuck, Sep 13 '15 at 10:45

Guffa · Accepted Answer · 2015-09-13T11:03:12.043

2

Dividing a floating point value by zero is not an error, the result just becomes infinity. Check the result after the division:

case '/':

  pp = Double.parseDouble(text.getText().toString());


  if (sss == '/') {

    vis = tt / pp;

    if (Double.isInfinite(vis)) {
      text.setText("");
      text2.setText("");
      Toast.makeText(getBaseContext(), "Cannot divide by zero", Toast.LENGTH_SHORT).show();
    } else {

      temp = (int) vis;
      if (vis == temp) {
        text.setText(Integer.toString(temp));
      } else {
        text.setText(Double.toString(vis));
      }

      vis = 0;
      ash = 0;
      break;

    }
  }

edited Sep 13 '15 at 11:03

answered Sep 13 '15 at 10:21

Guffa

687,336
108
737
1,005

Thank's ♥ But .isInfinity is'nt true - You Should type .isInfinite ;) good luck to you – Bigeye Sep 13 '15 at 10:42
@obj: I corrected the code above for future visitors. :) – Guffa Sep 13 '15 at 11:04

score 0 · Answer 2 · answered Sep 13 '15 at 10:39

Don't make your code so complex. Use just Double variable as in division you need answer to certain precision.Also there is problem with division operation with double type variables as they don't throw Arithmetic exception.E.g.:

0/0 - generates ArithmeticException
1.0/0 - generates output NaN(infinite)

It seams that "pp" is of double type. So write some thing like this:

double tt=Double.parseDouble(textView1.getText().toString().trim());
double pp=Double.parseDouble(textView2.getText().toString().trim());

if(pp!=0){
    x=tt/pp;
    System.out.println(" res :"+x);
}else{
    //you logic if pp is 0
}

Avoid computation if denominator is zero by using simple check(denominator==0) or keep as it so that when denominator is zero it shows result NaN(infinite).

how to fix divide by zero in android

2 Answers2