update a field in database

Question

I wrote this code to update a field in database but this field isn't updated.
I think the problem is related the find control cause I try that and it couldn't find my control.

C# code:

protected void btnCh_Click(object sender, EventArgs e)
{
    SqlConnection db = new SqlConnection(strcon);
    foreach (RepeaterItem repeaterItem in Repeater1.Items)
    {
        CheckBox CheckBox1 = (CheckBox)repeaterItem.FindControl("CheckBox1");
        if (CheckBox1.Checked)
        {
            db.Open();
            Label mylbl = (Label)repeaterItem.FindControl("mylbl");
            string mm= mylbl.Text;
            SqlCommand MyCMD = new SqlCommand("Update BuyGem Set GemChargeStatuse=1 ,Apple_gmail_Pass='' WHERE ID=@ID");
            MyCMD.Parameters.AddWithValue("@ID", mm);
            MyCMD.ExecuteNonQuery();
            db.Close();
        }
    }
}

Aspx code:

 <div class="col-md-12">
    <asp:Repeater ID="Repeater1" runat="server">
        <ItemTemplate>
            <div class="col-md-12">
                <div class=" pull-right  col-sm-6 animated2 bounceInLeft">
                    <div class="panel panel-primary ">
                        <asp:Label ID="mylbl" runat="server" ><%#Eval("ID")%></asp:Label>
                        <div class="panel-body" dir="rtl">
                            Name :
                            <asp:Label ID="lblname" runat="server"><%#Eval("Name") %></asp:Label>
                            <br />
                            <div class="col-md-9 pull-left col-xs-12 top15">
                                select:
                                <asp:CheckBox ID="CheckBox1" runat="server" />
                            </div>
                        </div>
                    </div>
                </div>
            </div>
        </ItemTemplate>
    </asp:Repeater>
    <asp:Button ID="btnCh" runat="server" Text="Button" OnClick="btnCh_Click" />
</div>

I should tell that the problem is not related to update command.I have tested and found out that the problem is related to findconrol that can't find any control in my repeater.please review your answers.

Soooo what's the problem? And have you step-through debugged your code? — Dai, Sep 14 '15 at 08:49
I tried many way to find the problem.I didn't get any error just my field in data base isn't updated. — moon light, Sep 14 '15 at 09:05

score 1 · Answer 1 · edited May 23 '17 at 12:22

1

replace

 SqlCommand MyCMD = new SqlCommand("Update BuyGem Set GemChargeStatuse=1 ,Apple_gmail_Pass='' WHERE ID=@ID");
MyCMD.Parameters.AddWithValue("@ID", mm);

to

 SqlCommand MyCMD = new SqlCommand("Update BuyGem Set GemChargeStatuse=1 ,Apple_gmail_Pass='' WHERE ID=@ID",db);
MyCMD.Parameter.Add("@ID",SqlDbType.Int).Value=mm;

see Difference between Parameters.Add and Parameters.AddWithValue

edited May 23 '17 at 12:22

Community

1
1

answered Sep 14 '15 at 08:57

A_Sk

4,532
3
27
51

no it is not work.my connection and update command don't have any problem. – moon light Sep 14 '15 at 10:37
there isn't an error.just i can't find my controls so i can't update my table – moon light Sep 14 '15 at 11:38

score 0 · Answer 2 · answered Sep 14 '15 at 08:49

Is your ID parameter in the Database a varchar or integer? Because currently

SqlCommand MyCMD = new SqlCommand("Update BuyGem Set GemChargeStatuse=1 ,Apple_gmail_Pass='' WHERE ID=@ID");
MyCMD.Parameters.AddWithValue("@ID", mm);

you are searching by string, where you shold be converting the string to integer like so:

int.Parse(idStringHere);

score 0 · Answer 3 · answered Sep 14 '15 at 08:59

0

MyCMD isn't associated with the db connection. Use something like:

var MyCMD = db.CreateCommand();

answered Sep 14 '15 at 08:59

AlexB

91
1
8

Put a try catch block around your code and see if any exceptions are being thrown. Also check the result of ExecuteNonQuery() to see if it is greater than 0. That method returns the number of rows that have been affected by the query, in this case it should be 1. – AlexB Sep 14 '15 at 10:53
you know the problem is related to my findcontrol.i am sure – moon light Sep 14 '15 at 11:39

update a field in database

3 Answers3