how to use delegatingFilterproxy in Java config?

Question

DelegatingFilterProxy has two constructors that I can use in my application

new DelegatingFilterProxy(String beanName);
new DelegatingFilterProxy(Filter delegate);

In my webappIntializer, I have the following. (please see below for full code).

servletContext.addFilter("counterMetricsFilter", new DelegatingFilterProxy("counterMetricsFilter").addMappingForUrlPatterns(null,
                false, MAPPING_URL);

I am not sure if DelegatingFilterProxy is functioning as expected in my case.

Controller

@Controller
@RequestMapping("/counter")
public class CounterController {

@Autowired
CounterManager manager;

 @RequestMapping(value = "/counterMetrics", method = RequestMethod.GET)
    @ResponseBody
    public Map getFeatureStatus(final HttpServletResponse response) {
        System.out.println("returning feautre status");
        return manager.getQueryCounts();
    }
}

Manager

@Service
public class CounterManager {

private Map<String,Integer> queryCounts =
            new ConcurrentHashMap<String,Integer>(1000);

int threshold;
long timestamp;

 @Autowired
  public CounterManager(@Value("${healthThreshold: 10}")
                                 int threshold) {
      this.threshold = threshold * MEGABYTES;
      this.timestamp = System.currentTimeMillis();
  }


 public void incrementRequestCounter(String urlPath){
     Integer oldVal, newVal;
     do {
       oldVal = queryCounts.get(model);
       newVal = (oldVal == null) ? 1 : (oldVal + 1);
     } while (!queryCounts.replace(model, oldVal, newVal));
 }

public Map<StatusUrlModel, Integer> getQueryCounts() {
    return queryCounts;
}

}

Filter

@Order(Ordered.HIGHEST_PRECEDENCE)
@Component(value="counterMetricsFilter")
public class CounterMetricsFilter extends OncePerRequestFilter {

    @Autowired
    CounterManager manager;

    @Override
    protected void doFilterInternal(HttpServletRequest request,
            HttpServletResponse response, FilterChain chain) throws ServletException,
            IOException {
        String path = new UrlPathHelper().getPathWithinApplication(request);
        try {
            chain.doFilter(request, response);
        }
        finally {
            recordMetrics(request, path);
        }
    }

   private void recordMetrics(String path) {
        try {
        manager.incrementRequestCounter(url);
        }
        catch (Exception ex){
            System.out.println("exception is thrown " + ex.getCause());
            ex.printStackTrace();
        }
    }
}

DelegatingFilterProxy

public class myAppWebAppInitializer implements WebApplicationInitializer {

             private static final String CONFIG_LOCATION = "com.myapp.sample.config";
            public static final String MAPPING_URL = "/*";

            @Override
            public void onStartup(ServletContext servletContext) throws ServletException {

     AnnotationConfigWebApplicationContext context = new AnnotationConfigWebApplicationContext();
    context.setConfigLocation(CONFIG_LOCATION);

                servletContext.addListener(new ContextLoaderListener(context));

                servletContext.addFilter("counterMetricsFilter", new DelegatingFilterProxy("counterMetricsFilter").addMappingForUrlPatterns(null,
            false, MAPPING_URL);

                ServletRegistration.Dynamic dispatcher = servletContext.addServlet("DispatcherServlet", new DispatcherServlet(
                        context));
                dispatcher.setLoadOnStartup(1);
                dispatcher.addMapping(MAPPING_URL);
            }

    }

NOTE: The container start-up fine. Requests go through fine. because this line manager.incrementRequestCounter(url) in CounterMetricsFilter above is throwing exception, and I am catching it, I see empty response. I suspect delegateFilterProxy is not autowiring properly.

Also Note that manager bean is loaded in Application Context because I can inspect the bean in CounterController.

I am unable to fix it. Any tips here would be very helpful.

EDIT

by changing to constructor injection instead of field injection in CounterMetricsFilter, I get the following exception.

//I removed the no-arg constructor above @Autowired public CounterMetricsFilter(HealthManager healthManager){ this.healthManager=healthManager; }

stacktrace

SEVERE: Exception starting filter counterMetricsFilter
org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 'counterMetricsFilter' is defined
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.getBeanDefinition(DefaultListableBeanFactory.java:638)
    at org.springframework.beans.factory.support.AbstractBeanFactory.getMergedLocalBeanDefinition(AbstractBeanFactory.java:1159)
    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:282)
    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:200)
    at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:979)
    at org.springframework.web.filter.DelegatingFilterProxy.initDelegate(DelegatingFilterProxy.java:324)
    at org.springframework.web.filter.DelegatingFilterProxy.initFilterBean(DelegatingFilterProxy.java:235)
    at org.springframework.web.filter.GenericFilterBean.init(GenericFilterBean.java:199)
    at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:281)
    at org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFilterConfig.java:111)
    at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4775)
    at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5452)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
    at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
    at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
    at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633)
    at org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1113)
    at org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1671)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
  [1]: http://stackoverflow.com/questions/32573742/why-is-autowired-bean-null-in-filter-in-this-spring-application

Answer 1

I don't see configuration class itself among the code snippets above, so listing the general solution how to make DelegatingFilterProxy work with Spring Java Config.

Initializer

public class MyWebAppInitializer implements WebApplicationInitializer {
    ...
    @Override
    public void onStartup(ServletContext servletContext) throws ServletException {
        ...
        servletContext.addFilter("myFilter", new DelegatingFilterProxy("myFilter"))
                .addMappingForUrlPatterns(null, true, "/*");
        ...
    }
    ...
}

Filter

public class MyFilter implements Filter {
    ...
    // I added this parameter just as example of how Spring-managed dependencies
    // could be injected. Note, there is no any annotations in this class.
    private String someParameter;
    public MyFilter(String someParameter) {
        this.someParameter = someParameter;
    }
    ...
}

Configuration

@Configuration
@EnableWebMvc
@PropertySource(value = {
        "classpath:my.properties"
})
@Import({
        PropertySourcesPlaceholderConfigurer.class
})
public class MyConfig {
    ...
    @Bean
    public MyFilter myFilter(@Value("${someParameter}") String someParameter) {
        return new MyFilter(someParameter);
    }
    ...
}

Hope it will be useful for someone.