Script for adding a disk to fstab if not existing

Question

First of all, I have read many posts (see at bottom) with if-clauses to search in a file for a specific string and followed these posts 1to1, however I don't manage to get my script to work. I want to make an entry in /etc/fstab if it doesn't exist yet:

#!/bin/bash
fstab=/etc/fstab

if grep -q "poky-disc" "$fstab"
then
    echo "#poky-disc" >> /etc/fstab
    echo "/dev/sdb1 /media/poky ext4 defaults 0 2" >> /etc/fstab
else
    echo "Entry in fstab exists."
fi

Thanks for your help in advance. These are the similar posts, which didnt help me further:

I tried it with inversion, too. `grep -q "poky-disc" "$fstab"`and `grep "poky-disc" "$fstab"` — h0ch5tr4355, Sep 25 '15 at 08:53
Oh damn through your impact I found out that `-q` isn't the option for Inversion, but just suspending the output, a short `man grep` helped me. And I was reading topics about paths and grep... — h0ch5tr4355, Sep 25 '15 at 09:01

score 9 · Accepted Answer · answered Aug 26 '19 at 12:29

Here's a simple and hopefully idiomatic solution.

grep -q 'init-poky' /etc/fstab || 
printf '# init-poky\n/dev/sdb1    /media/poky    ext4    defaults    0    2\n' >> /etc/fstab

If the exit status from grep -q is false, execute the printf. The || shorthand can be spelled out as

if grep -q 'ínit-poky' /etc/fstab; then
    : nothing
else
    printf ...
fi

Many beginners do not realize that the argument to if is a command whose exit status determines whether the then branch or the else branch will be taken.

Arunas Bartisius · Answer 2 · 2019-08-26T13:40:34.250

7

Elegant and short way:

#!/bin/bash
if ! grep -q 'init-poky' /etc/fstab ; then
    echo '# init-poky' >> /etc/fstab
    echo '/dev/sdb1    /media/poky    ext4    defaults    0    2' >> /etc/fstab
fi

It uses native Bash command exit code ($?=0 for success and >0 for error code) and if grep produces error, means NOT FOUND, it does inverse (!) of result, and adds fstab entry.

edited Aug 26 '19 at 13:40

answered Aug 26 '19 at 12:06

Arunas Bartisius

1,879
22
23

score 3 · Answer 3 · answered Nov 11 '19 at 15:04

3

I had the same issue. I managed to edit it with this command:

sudo su -c "echo '#test' >> /etc/fstab"

answered Nov 11 '19 at 15:04

Noy Tsarfaty

49
2

score 0 · Answer 4 · answered Sep 22 '16 at 17:18

0

#!/bin/bash
fstab=/etc/fstab

if [[ $(grep -q "poky-disc" "$fstab") ]]
# forgiving me for being a bit of over-rigorous, you might want to change this matching word, as below, 'poky-disc' merely a comment, not exactly a config line, so
then
    echo "#poky-disc" >> /etc/fstab
    echo "/dev/sdb1 /media/poky ext4 defaults 0 2" >> /etc/fstab
else
    echo "Entry in fstab exists."
fi

answered Sep 22 '16 at 17:18

kyokose

81
1
9

Thank you! Could you also explain the usage of the 2nd line "fstab=/etc/fstab" here? – Yiping Sep 07 '18 at 14:39
Creating an `fstab` variable doesn't make much sense as it is written. First of all it's always going to be `/etc/fstab`, but even if it were to change it wouldn't be helpful as you're not consistent in using the variable. – skyking Sep 18 '18 at 17:14
The command substitution is completely wrong here. You are checking if `grep -q` outputs a non-empty string, which of course it will never do. You simply want `if ! grep -q "poky-disc" "$fstab"; then` – tripleee Aug 26 '19 at 12:25
FWIW, this error is a duplicate of https://stackoverflow.com/questions/36371221/bash-if-statement-too-many-arguments – tripleee Sep 20 '21 at 05:49

Script for adding a disk to fstab if not existing

4 Answers4