Objective - C stringByAddingPercentEncodingWithAllowedCharacters not working

Question

I have a URL like so ANC & SHO.pdf

when I encode the URL like so:

NSString *escapedString = [PDFPath stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]];

now when I use this URL it does not work and I have a feeling it has to do with the & because when I tried another file, it worked perfectly I was able to load the PDF, but with the file with & I was not.

What Am I doing wrong?

Here is the output of escapedString

escapedString   __NSCFString *  @"Ancaster%5CANC%20&%20SHO%20-%20Laundry%20Closets%20to%20be%20Checked.pdf" 0x16ea33c0

I then use that to call a method:

NSArray *byteArray = [dataSource.areaData GetPDFFileData:[NSString stringWithFormat:@"%@",escapedString]];

Here is the method:

-(NSArray *)GetPDFFileData:(NSString *)PDFFile
{
    NSString *FileBrowserRequestString = [NSString stringWithFormat:@"%@?PDFFile=%@",kIP,PDFFile];
    NSURL *JSONURL = [NSURL URLWithString:FileBrowserRequestString];
    NSURLResponse* response = nil;
    NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:JSONURL];
    NSData* data = [NSURLConnection sendSynchronousRequest:request returningResponse:&response error:nil];
    if(data == nil)
        return nil;
    NSError *myError;
    NSArray *tableArray = [[NSArray alloc]initWithArray:[NSJSONSerialization JSONObjectWithData:data options:kNilOptions error:&myError]];
    return tableArray;
}

escapedString __NSCFString * @"Ancaster%5CANC%20&%20SHO%20-%20Laundry%20Closets%20to%20be%20Checked.pdf" 0x16ea33c0 — user979331, Sep 28 '15 at 13:31
That looks OK. How are you using the string to fetch the file? — Droppy, Sep 28 '15 at 13:34
possible duplicate of [How do I URL encode a string](http://stackoverflow.com/questions/8088473/how-do-i-url-encode-a-string) — Droppy, Sep 28 '15 at 13:57
you are using different method, you need to add escape characters into your string, use `[@"Your URL string" stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]` — Dipen Panchasara, Sep 28 '15 at 14:02

score 15 · Accepted Answer · edited May 23 '17 at 12:00

[NSCharacterSet URLHostAllowedCharacterSet] contains characters below:

!$&'()*+,-.0123456789:;=ABCDEFGHIJKLMNOPQRSTUVWXYZ[]_abcdefghijklmnopqrstuvwxyz~

which contains '&', so

NSString *escapedString = [PDFPath stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]];

won't escape '&' for you, then it's not URLEncoded.

see the question about how to url encode a string.

Objective - C stringByAddingPercentEncodingWithAllowedCharacters not working

1 Answers1