python module imports issue

Question

here's a picture of my directory structure:

parts.py
machine/
    __init__.py
    parts.py

I have a directory (a package) called machine

in it there is __init__.py and parts.py

at the same level as machine, there is a file named parts.py

in parts.py, the code looks like this:

#parts.py
class Parts(object):
    pass

in machine.parts the code looks like this

 #machine.parts
 from parts import Parts
 class MachineParts(Parts):
     pass

When I try to import machine.parts, I get an import error. I don't want to change my directory structure. How should I fix this and retain good PEP8 style?

in machine.parts what do you mean by `from Parts import Parts` — praba230890, Sep 30 '15 at 03:18
You should make it all a package (by adding `__init__.py` near `parts.py`) and use absolute imports, like `from mypackage.parts import Parts`. — alexanderlukanin13, Sep 30 '15 at 03:37

score 1 · Accepted Answer · answered Sep 30 '15 at 03:42

You should make it a package by adding top-level __init__.py and giving some meaningful name to top-level directory:

mypackage
    __init__.py
    parts.py
    machine/
        __init__.py
        parts.py

Then, use absolute imports:

#machine.parts
from mypackage.parts import Parts
class MachineParts(Parts):
    pass

score 0 · Answer 2 · edited May 23 '17 at 12:06

0

Since import supports relative imports, try:

from ..parts import Parts

Another option is to use an absolute import:

from appname.parts import Parts

As mentioned in How to import a Python class that is in a directory above?

edited May 23 '17 at 12:06

Community

1
1

answered Sep 30 '15 at 03:30

Sina Khelil

2,001
1
18
27

relative imports are considered bad style – pepper Sep 30 '15 at 03:31
1

but it is part of PEP328 - how is that bad style? Naming files the same name might be considered bad style as well... confusing for your fellow developer (conside `parent_parts.py`?) – Sina Khelil Sep 30 '15 at 03:32
fair enough, I only read not to use relative imports in the google styleguide. Relative imports don't work here though – pepper Sep 30 '15 at 03:37
use an absolute import (although frowned upon as well) – Sina Khelil Sep 30 '15 at 03:42

python module imports issue

2 Answers2