Why is it bad to write such a code?
Element.prototype.hide = function () { this.hidden = true };
Element.prototype.show = function () { this.hidden = false };
Asked
Active
Viewed 227 times
-1
Mr. Alien
- 153,751
- 34
- 298
- 278
Taras Mazurkevych
- 151
- 7
-
1Some reading: http://perfectionkills.com/extending-native-builtins/ – pawel Oct 02 '15 at 09:54
-
1And previously on SO: http://stackoverflow.com/questions/14034180/ – pawel Oct 02 '15 at 09:55
1 Answers
3
You mean to change native JS prototypes(like String) or in general?
Changing native prototypes can be problematic since you can never know if there is another library, which does the same but gives e.g. slightly different results.
Changing prototypes of your objects / third-party libraries is perfectly fine because this is how polymorphism in JS can be achieved.
kamil-mrzyglod
- 4,948
- 1
- 20
- 29
-
I mean to change native js prototypes. Is it only one reason that other libraries can change them too? – Taras Mazurkevych Oct 02 '15 at 17:14
-
Of course not but this is the main reason - to avoid confusion. – kamil-mrzyglod Oct 02 '15 at 20:20