PHP Using call_user_func_array to bind_param

Question

i had problem INSERT data to mysql using PHP OOP.

so, this is my code :

public function insert($setType, $setTable, $setRow, $setValues) {

        $change = function($values) {
            return "?";
        };

        $row = join(",", $setRow);

        $done = join(",", array_map($change, $setValues));  

        $values[] = join(",", $setValues);

        function SqlArrayReferenceValues($arr){
         if (strnatcmp(phpversion(),'5.3') >= 0) {
            $refs = array();
            foreach($arr as $key => $value)
            $refs[$key] = &$arr[$key];
            return $refs;
            }
        return $arr;
        }

        $insert = $this->connect->prepare("INSERT INTO $setTable ($row) VALUES ($done)");

        $mergedValues = array_merge(array($setType), $values);
        call_user_func_array(array($insert, "bind_param"), SqlArrayReferenceValues($mergedValues));


        $insert->execute();
        $insert->close();

        return $insert;     
    }

if (empty($_SESSION['transaction'])) :

$idt = date("ymdhis");

$_SESSION['transaction'] = $idt;
endif;

$st = $_SESSION['transaction'];

if (isset($_SESSION['email'])) :

$se = $_SESSION['email'];

$user = $objMysql->query(array("*"), "user", "email = '$se'");
    $dataUser = $objMysql->fetch($user);

$ide = $dataUser['id_user'];
else :
$ide = 0;
endif;

$currentLink = "http://$_SERVER[HTTP_HOST]$_SERVER[REQUEST_URI]";
$objMysql->insert("sis", "url", array("id_transaction", "id_user", "url"), array("$st", "$ide", "$currentLink"));

this is my mysql table : id_transaction row - type varchar. id_user row - type INT url row - type text

i got 1 errors,

1. mysqli_stmt::bind_param(): Number of elements in type definition string doesn't match number of bind variables in

what's wrong with my code?

FINAL SOLUTION BY MARTIN

public function SqlArrayReferenceValues($arr){
    if (strnatcmp(phpversion(),'5.3') >= 0) {
        $refs = array();
        foreach($arr as $key => $value)
            $refs[$key] = &$arr[$key];
        return $refs;
    }
    return $arr;
}

    public function insert($setType, $setTable, $setRow, $setValues) {

        $change = function($values) {
            return "?";
        };

        $row = join(",", $setRow);

        $done = join(",", array_map($change, $setValues));          
        $insert = $this->connect->prepare("INSERT INTO $setTable ($row) VALUES ($done)");

        $params = $setValues;

        $ww = array_merge(array($setType), $params);
        call_user_func_array(array($insert, "bind_param"), $this->SqlArrayReferenceValues($ww));


        $insert->execute();
        $insert->close();

        return $insert;     
    }

Answer 1

As correctly noted in comments, by Mark Baker and bub, you are passing a string value in the place of an array value.

What you have is an array of values you then turn into a string, before then trying to use them as an array. There is no need use join on the $values variable.

//$values = join(",", $setValues); // comment out this line,

 call_user_func_array(array($insert, "bind_param"), array_unshift(array($setType), $setValues));

Here you use array_unshift to insert the array TYPES that you passed to the function, at the start of the array. This will now give you a correct array to insert into bind_param:

array("sis", $st, $side, $currentLink);

Problems with expected by reference:

There is an issue with the above that the MySQLi OOP code expects objects as references, so as well as the above- the values needs to be run through a separate process to give their "true" values to the call_user_func_array() function.

In your class/script add:

 private function SqlArrayReferenceValues($arr){
        if (strnatcmp(phpversion(),'5.3') >= 0) {
            $refs = array();
            foreach($arr as $key => $value)
                $refs[$key] = &$arr[$key];
            return $refs;
        }
        return $arr;
    }

This function takes the values and returns the correct value types to the call_user_array_function.

so:

$mergedValues = array_unshift($setValues, $setType);
call_user_func_array(array($insert, "bind_param"), $this->SqlArrayReferenceValues($mergedValues));

I got this code from somewhere on Stack Overflow and it's been very useful for years! This is the link: https://stackoverflow.com/a/16120923/3536236

Update 3:

How your code should look:

private function SqlArrayReferenceValues($arr){
         if (strnatcmp(phpversion(),'5.3') >= 0) {
            $refs = array();
            foreach($arr as $key => $value)
            $refs[$key] = &$arr[$key];
            return $refs;
            }
        return $arr;
        }

public function insert($setType, $setTable, $setRow, $setValues) {

        $change = function($values) {
            return "?";
        };
        $row = join(",", $setRow);
        $setValuesCopy = $setValues;
        $done = join(",", array_map($change, $setValuesCopy));      
        $insert = $this->connect->prepare("INSERT INTO ".$setTable." (".$row.") VALUES (".$done.")");

        $mergedValues = array_unshift($setValues, $setType);
        //probably not needed but resetting array numerical indexing:
        $mergedValues = array_values($mergedValues); 
        call_user_func_array(array($insert, "bind_param"), $this->SqlArrayReferenceValues($mergedValues));
        $insert->execute();
        $insert->close();
        return $insert;     
    }

$currentLink = "http://".$_SERVER[HTTP_HOST].$_SERVER[REQUEST_URI]";
$objMysql->insert("sis", "url", array("id_transaction", "id_user", "url"), array($st, $ide, $currentLink));