HttpURLConnection error

Question

I want to get the HTML from a website, for that I'm using this code. When I try to add this code from the documentation I get this error:

            //Get HTML
            URL url = new URL("http://www.android.com/");
            HttpURLConnection urlConnection = (HttpURLConnection) url.openConnection();
            try {
                InputStream in = new BufferedInputStream(urlConnection.getInputStream());
                readStream(in);
                finally {
                    urlConnection.disconnect();
                }
            }

What went wrong? Did I forget to import some stuff?

On the first one: "Unhandled exception: java.net.MalformedURLException". The 2th en 3th one: "Unhandled exception: java.io.IOException" — Jan Koekepan, Oct 07 '15 at 13:30

score 1 · Accepted Answer · edited Mar 30 '16 at 08:32

1

You didn't forget to import anything.

There's a couple things wrong with the code.

1) You're missing the catch block to go along with try and your finally statement is incorrectly inside the if. It should look like the follow:

try {
    InputStream in = new BufferedInputStream(urlConnection.getInputStream());
    readStream(in);
} catch (Exception e) { // best practice is to be more specific with the Exception type
    urlConnection.disconnect();
    Log.w("Login", "Error downloading HTML from " + url);        
} finally {
    if(urlConnection != null) {
                urlConnection.disconnect();
    }
}

2) In that example you are following in the documentation, they are leaving it up to you to decide what to do with the stream once it it retrieved from the urlConnection.

So create your own void readStream(InputStream in) method in your activity which can then consume the InputStream. Write it to disk, display it on screen, its up to you.

edited Mar 30 '16 at 08:32

Vishudh Sasidharan

329
4
9

answered Oct 07 '15 at 13:25

Jon Finerty

198
1
8

And if I want the result to a String, I can use: String example = urlConnection.toString(); – Jan Koekepan Oct 07 '15 at 13:33
Because I want to print to a EditText field. – Jan Koekepan Oct 07 '15 at 13:37
This question: http://stackoverflow.com/questions/309424/read-convert-an-inputstream-to-a-string will help you getting your inputstream into a stream. – Jon Finerty Oct 07 '15 at 13:48
This answer specifically will help you, without needing external libraries: http://stackoverflow.com/a/10505933/798464 – Jon Finerty Oct 07 '15 at 13:51
I use this code with an onClicklistener now, only still it isnt working. Nothing shows up in my EditText field. – Jan Koekepan Oct 14 '15 at 17:49

score 0 · Answer 2 · answered Oct 07 '15 at 13:22

0

You are missing the catch clause. Put this before your finally clause as such:

} catch (Exception e) { //it's bad practice to catch Exception, specify it more if you can, i just don't know what errors InputStream throws
    Log.e("ClassTag", e.getMessage(), e);
} finally { /* ... */ }

answered Oct 07 '15 at 13:22

nbokmans

5,492
4
35
59

My bad. Didn't know that, now I do. – nbokmans Oct 07 '15 at 13:31

score 0 · Answer 3 · answered Oct 07 '15 at 13:23

The finally block does not go inside the try block, change it to:

 try {
     InputStream in = new BufferedInputStream(urlConnection.getInputStream());
     readStream(in);
 }
 finally {
    urlConnection.disconnect();
}

Also make sure that you have imported java.net.URL.

HttpURLConnection error

3 Answers3