Cannot implicitly convert type 'decimal?' to 'decimal'

Question

The PriceOffer property is nullable of decimal

 List<TopRated> TopRated = (from review in db.ProductReviews
                            group review by review.ProductID into product
                            select new TopRated
                            {
                              ProductName = product.Select(p => p.Products.Name).FirstOrDefault(),
                              Price = product.Select(p => p.Products.Price).FirstOrDefault(),
                              PriceOffer = product.Select(p => p.Products.PriceOffer).FirstOrDefault(),
                              ProductId = product.Key,
                              AverageRating = product.Average(p => p.Rating)
                            }).ToList();

Is the `PriceOffer` property on `TopRated` also `decimal?`? – Dave Zych Oct 09 '15 at 18:27 — Dave Zych, Oct 09 '15 at 18:27
The error message seems to be pretty clear, right? – Sybren Oct 09 '15 at 18:27 — Sybren, Oct 09 '15 at 18:27
@DaveZych It now is. Do you mind posting it as an answer? – OrElse Oct 09 '15 at 18:36 — OrElse, Oct 09 '15 at 18:36

AlexD · Answer 1 · 2015-10-09T18:33:11.300

12

To convert from decimal? to decimal, try Value:

decimal? d = 0;
decimal d1 = d.Value;

As @Tim commented, it throws exception if decimal? has no value.

Depending on your logic, you may try something like

decimal d1 = d.HasValue? d.Value: 0;

or just

decimal d2 = d ?? 0;

edited Oct 09 '15 at 18:33

answered Oct 09 '15 at 18:28

AlexD

32,156
3
71
65

score 0 · Answer 2 · edited May 23 '17 at 12:14

0

Probably this product.Select(p => p.Products.PriceOffer).FirstOrDefault() returns a decimal type. You can't type decimal to nullable decimal.

Here you can fin examples of such a casting: How can I convert decimal? to decimal

edited May 23 '17 at 12:14

Community

1
1

answered Oct 09 '15 at 18:31

Andrius

136
4

"You can't type decimal to nullable decimal." - it is the other way around - as the error message indicates. – Igor Oct 09 '15 at 18:32

Cannot implicitly convert type 'decimal?' to 'decimal'

2 Answers2