PHP getting all files in subdirectories

Question

I am trying to get all XML files in my 10 subfolders and parse them. To do that I have the following code:

public static function calculateEAXML ($dir) {
$dh  = opendir($dir);
$folderNames = array();
$arr = array();
while (false !== ($folderName = readdir($dh))) {
  if ( $folderName[0] == "." || (substr($folderName, -3) == "zip") ) {continue;}
  $folderNames[] = $folderName; 
  $dom = new DOMDocument;
  $dom->validateOnParse = true;
  foreach ($folderNames as $file) 
{
    if(is_dir($folderName)){ScanFiles::calculateEAXML($dir);}
    else{
    $df  = opendir($dir . $file);
    while (false !== ($file = readdir($df))) 
    {
        if ($file == "." || $file == ".."  ) {continue;}
        $dom->Load($dir . $folderName . "/" . $file);
        $arr[] = XML2Array::createArray($dom);
    }
  }
}
  return $arr;    
}
}

The thing is it parses the files only in ONE directory completely ignoring the other. Are there any ideas how to make it parse all the files in ALL directories?

maybe this will help: http://stackoverflow.com/a/1860417/5440709 — Kanti, Oct 13 '15 at 14:42

score 0 · Answer 1 · answered Oct 13 '15 at 15:10

0

This is what glob is for:

foreach (glob("*.xml") as $filename) {
    // do sth with the file, $filename holds the current file
}

answered Oct 13 '15 at 15:10

Jan

42,290
8
54
79

score 0 · Accepted Answer · answered Oct 13 '15 at 15:17

There are a number of problems with your script, mostly around the foreach.

if(is_dir($folderName)): The variable $folderName doesn't exist. I would assume that you should have $file there.
ScanFiles::calculateEAXML($dir);: You're scanning the same directory again, and doing nothing with the response.
$df = opendir($dir . $file);: If the file isn't a directory, you're trying to open it as a directory.
Your foreach loop is inside the while loop.

Here's an attempt at fixing those problems:

public static function calculateEAXML($dir) {
    $dh  = opendir($dir);
    $folderNames = array();
    $arr = array();

    // Get all files and folders in the current directory
    while (false !== ($folderName = readdir($dh))) {
        if ($folderName[0] == "." || (substr($folderName, -3) == "zip")) {
            continue;
        }
        $folderNames[] = $folderName;
    }

    foreach ($folderNames as $file) {
        $filename = $dir . '/' . $file;
        if(is_dir($filename)){
            $arr = array_merge($arr, ScanFiles::calculateEAXML($filename));
        } else {
            $dom = new DOMDocument;
            $dom->validateOnParse = true;
            $dom->Load($filename);
            $arr[] = XML2Array::createArray($dom);
        }
    }
    return $arr;    
}

Very big Thank You! Works as expected!! – Jack Oct 13 '15 at 15:55 — Jack, Oct 13 '15 at 15:55

PHP getting all files in subdirectories

2 Answers2