1

This question DOES NOT already has an answer here: PDO Statement Returns FALSE 1 answer

The above question is only error handling see the errors I get! (already have error handling) and all my queries are working if I run them in phpmyadmin.

Hi I am trying to get paging into my dynamic page. But I get the warning:

Warning: Invalid argument supplied for foreach() on line 137

I have tried to fix it but I can seem to get it to work. I have tried to change 

foreach($results as $row)

To: 

foreach($row = $results->fetch(PDO::FETCH_ASSOC))

And

foreach($row = $results->fetchAll())

But than I get the error:

Parse error: syntax error, unexpected ')' on line 137

I have tried to find the answer on the internet but i can find one that fixes this problem.

Does somebody know how I can fix this? And what I am doing wrong... I try to work with PDO. I am a still a little new to PHP and PDO.

My code:

    <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script> 
<?php 
    include('php/loginHandlerconnect.php'); 

    ini_set('display_errors',1);
    ini_set('display_startup_errors',1);
    error_reporting(-1);

    $db = loginHandlerconnect(); 

    //$tableName="vacature";        
    $targetpage = "vacatureoverzicht";  
    $limit = 10; 

    $query = "SELECT COUNT(vacatureID) as num FROM vacature";
    $res = $db->query($query);
    $total_pages = $res->fetch(PDO::FETCH_ASSOC);
    $total_pages = $total_pages['num'];

    $stages = 3;
    $page = $db->quote($_GET['page']);
    if($page){
        $start = ($page - 1) * $limit; 
    }else{
        $start = 0; 
    }

    $sql = 'SELECT vacature.*, werkgever.image, werkgever.plaats, werkgever.provincie, werkgever.naamBedrijf FROM vacature LEFT JOIN werkgever ON (vacature.werkgeverID = werkgever.werkgeverID) ORDER BY vacature.datum DESC LIMIT '. $start .', '. $limit .''; 
    $results = $db->query($sql); 

    // Initial page num setup
    if ($page == 0){$page = 1;}
    $prev = $page - 1;  
    $next = $page + 1;                          
    $lastpage = ceil($total_pages/$limit);      
    $LastPagem1 = $lastpage - 1;                    


    $paginate = '';
    if($lastpage > 1)
    {   
        $paginate .= "<div class='paginate'>";
        // Previous
        if ($page > 1){
            $paginate.= "<a href='$targetpage?page=$prev'>previous</a>";
        }else{
            $paginate.= "<span class='disabled'>previous</span>";   }

        // Pages    
        if ($lastpage < 7 + ($stages * 2))  // Not enough pages to breaking it up
        {   
            for ($counter = 1; $counter <= $lastpage; $counter++)
            {
                if ($counter == $page){
                    $paginate.= "<span class='current'>$counter</span>";
                }else{
                    $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
            }
        }
        elseif($lastpage > 5 + ($stages * 2))   // Enough pages to hide a few?
        {
            // Beginning only hide later pages
            if($page < 1 + ($stages * 2))       
            {
                for ($counter = 1; $counter < 4 + ($stages * 2); $counter++)
                {
                    if ($counter == $page){
                        $paginate.= "<span class='current'>$counter</span>";
                    }else{
                        $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
                }
                $paginate.= "...";
                $paginate.= "<a href='$targetpage?page=$LastPagem1'>$LastPagem1</a>";
                $paginate.= "<a href='$targetpage?page=$lastpage'>$lastpage</a>";       
            }
            // Middle hide some front and some back
            elseif($lastpage - ($stages * 2) > $page && $page > ($stages * 2))
            {
                $paginate.= "<a href='$targetpage?page=1'>1</a>";
                $paginate.= "<a href='$targetpage?page=2'>2</a>";
                $paginate.= "...";
                for ($counter = $page - $stages; $counter <= $page + $stages; $counter++)
                {
                    if ($counter == $page){
                        $paginate.= "<span class='current'>$counter</span>";
                    }else{
                        $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
                }
                $paginate.= "...";
                $paginate.= "<a href='$targetpage?page=$LastPagem1'>$LastPagem1</a>";
                $paginate.= "<a href='$targetpage?page=$lastpage'>$lastpage</a>";       
            }
            // End only hide early pages
            else
            {
                $paginate.= "<a href='$targetpage?page=1'>1</a>";
                $paginate.= "<a href='$targetpage?page=2'>2</a>";
                $paginate.= "...";
                for ($counter = $lastpage - (2 + ($stages * 2)); $counter <= $lastpage; $counter++)
                {
                    if ($counter == $page){
                        $paginate.= "<span class='current'>$counter</span>";
                    }else{
                        $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
                }
            }
        }

                // Next
        if ($page < $counter - 1){ 
            $paginate.= "<a href='$targetpage?page=$next'>next</a>";
        }else{
            $paginate.= "<span class='disabled'>next</span>";
            }

        $paginate.= "</div>";       
    }
    echo $total_pages.' Results';
    // pagination
    echo $paginate; 

    /*
    ini_set('display_errors',1);
    ini_set('display_startup_errors',1);
    error_reporting(-1);
    */
    /* 
    * Nu hebben we een resultset met de volgende data per row 
    * vacatureID 
    * werkgeverID 
    * functie 
    * datum 
    * omschrijvingKort 
    * omschrijving 
    * image (werkgever) 
    * plaats (werkgever) 
    * provincie (werkgever) 
    * naamBedrijf (werkgever) 
    */ 
    foreach($results as $row) // line 137
    { 
        //Clean record 
        cleanRecord($row);
        echo generateDiv($row); 
    }

    function cleanRecord($row) 
    { 
        if (strlen($row['functie']) > 20) { 

            // truncate string 
            $stringCut = substr($row['functie'], 0, 20); 

            // make sure it ends in a word so assassinate doesn't become ass... 
            $row['functie'] = substr($stringCut, 0, strrpos($stringCut, ' ')).'...'; 
        } 
        if (strlen($row['naamBedrijf']) > 25) { 

            // truncate string 
            $stringCut2 = substr($row['naamBedrijf'], 0, 14); 

            // make sure it ends in a word so assassinate doesn't become ass... 
            $row['naamBedrijf'] = substr($stringCut2, 0, strrpos($stringCut2, ' ')).'...'; 
        } 
        if (strlen($row['omschrijvingKort']) > 63) { 

            // truncate string 
            $stringCut2 = substr($row['omschrijvingKort'], 0, 63); 

            // make sure it ends in a word so assassinate doesn't become ass... 
            $row['omschrijvingKort'] = substr($stringCut2, 0, strrpos($stringCut2, ' ')).'...'; 
        } 

        return $row; 
    } 
    function generateDiv($row) 
    { 
        $date = date("d-m-Y", strtotime($row['datum'])); 
        return " 
            <div class='vacatureinfo2'> 
                <img class='userimg2' src='../../uploads/userimage/". $row['image'] ."' id='imge'/> 
                <p class='func-br-pl pull-left'>". $row['functie'] ." - ". $row['naamBedrijf'] ." - ". $row['plaats'] ."</p><p class='dtm pull-right'>". $date ."</p> 
                <div class='omschrijvingkort2'> 
                    ". $row['omschrijvingKort'] ." 
                </div> 
                <p class='pull-right'><a href='reactie?id=" . $row['vacatureID'] . "'>Reageer</a> | <a href='informatie-vacature?id=" . $row['vacatureID'] . "'>Meer informatie</a></p> 
            </div> 
            <hr> 
        "; 
    }
?>

UPDATE:

    <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script> 
<?php 
    include('php/loginHandlerconnect.php'); 

    ini_set('display_errors',1);
    ini_set('display_startup_errors',1);
    error_reporting(-1);

    $db = loginHandlerconnect(); 

    $targetpage = "vacatureoverzicht";  
    $limit = 10; 

    $query = "SELECT COUNT(vacatureID) as num FROM vacature";
    $res = $db->query($query);
    $total_pages = $res->fetch(PDO::FETCH_ASSOC);
    $total_pages = $total_pages['num'];

    $stages = 3;
    $page = $db->quote($_GET['page']);
    if($page){
        $start = ($page - 1) * $limit; 
    }else{
        $start = 0; 
    }

    $sql = $db->query('SELECT vacature.*, werkgever.image, werkgever.plaats, werkgever.provincie, werkgever.naamBedrijf FROM vacature LEFT JOIN werkgever ON (vacature.werkgeverID = werkgever.werkgeverID) ORDER BY vacature.datum DESC LIMIT '. $start .', '. $limit .''); 
    $results = $sql->fetchAll();

    // Initial page num setup
    if ($page == 0){$page = 1;}
    $prev = $page - 1;  
    $next = $page + 1;                          
    $lastpage = ceil($total_pages/$limit);      
    $LastPagem1 = $lastpage - 1;                    


    $paginate = '';
    if($lastpage > 1)
    {   
        $paginate .= "<div class='paginate'>";
        // Previous
        if ($page > 1){
            $paginate.= "<a href='". $targetpage ."?page=". $prev ."'>previous</a>";
        }else{
            $paginate.= "<span class='disabled'>previous</span>";   
        }

        // Pages    
        if ($lastpage < 7 + ($stages * 2))  // Not enough pages to breaking it up
        {   
            for ($counter = 1; $counter <= $lastpage; $counter++)
            {
                if ($counter == $page){
                    $paginate.= "<span class='current'>". $counter ."</span>";
                }else{
                    $paginate.= "<a href='". $targetpage ."?page=". $counter ."'>". $counter ."</a>";}                  
            }
        }
        elseif($lastpage > 5 + ($stages * 2))   // Enough pages to hide a few?
        {
            // Beginning only hide later pages
            if($page < 1 + ($stages * 2))       
            {
                for ($counter = 1; $counter < 4 + ($stages * 2); $counter++)
                {
                    if ($counter == $page){
                        $paginate.= "<span class='current'>". $counter ."</span>";
                    }else{
                        $paginate.= "<a href='". $targetpage ."?page=". $counter ."'>". $counter ."</a>";}                  
                }
                $paginate.= "...";
                $paginate.= "<a href='". $targetpage ."?page=". $LastPagem1 ."'>". $LastPagem1 ."</a>";
                $paginate.= "<a href='". $targetpage ."?page=". $lastpage ."'>". $lastpage ."</a>";     
            }
            // Middle hide some front and some back
            elseif($lastpage - ($stages * 2) > $page && $page > ($stages * 2))
            {
                $paginate.= "<a href='". $targetpage ."?page=1'>1</a>";
                $paginate.= "<a href='". $targetpage ."?page=2'>2</a>";
                $paginate.= "...";
                for ($counter = $page - $stages; $counter <= $page + $stages; $counter++)
                {
                    if ($counter == $page){
                        $paginate.= "<span class='current'>". $counter ."</span>";
                    }else{
                        $paginate.= "<a href='". $targetpage ."?page=". $counter ."'>". $counter ."</a>";}                  
                }
                $paginate.= "...";
                $paginate.= "<a href='". $targetpage ."?page=". $LastPagem1 ."'>". $LastPagem1 ."</a>";
                $paginate.= "<a href='". $targetpage ."?page=". $lastpage ."'>". $lastpage ."</a>";     
            }
            // End only hide early pages
            else
            {
                $paginate.= "<a href='". $targetpage ."?page=1'>1</a>";
                $paginate.= "<a href='". $targetpage ."?page=2'>2</a>";
                $paginate.= "...";
                for ($counter = $lastpage - (2 + ($stages * 2)); $counter <= $lastpage; $counter++)
                {
                    if ($counter == $page){
                        $paginate.= "<span class='current'>". $counter ."</span>";
                    }else{
                        $paginate.= "<a href='". $targetpage ."?page=". $counter ."'>". $counter ."</a>";}                  
                }
            }
        }

                // Next
        if ($page < $counter - 1){ 
            $paginate.= "<a href='". $targetpage ."?page=". $next ."'>next</a>";
        }else{
            $paginate.= "<span class='disabled'>next</span>";
            }

        $paginate.= "</div>";       
    }
    echo $total_pages.' vacatures';

    /*
    ini_set('display_errors',1);
    ini_set('display_startup_errors',1);
    error_reporting(-1);
    */
    /* 
    * Nu hebben we een resultset met de volgende data per row 
    * vacatureID 
    * werkgeverID 
    * functie 
    * datum 
    * omschrijvingKort 
    * omschrijving 
    * image (werkgever) 
    * plaats (werkgever) 
    * provincie (werkgever) 
    * naamBedrijf (werkgever) 
    */ 
    foreach($results as $row) 
    { 
        //Clean record 
        cleanRecord($row);
        echo generateDiv($row); 
    }

    function cleanRecord($row) 
    { 
        if (strlen($row['functie']) > 20) { 

            // truncate string 
            $stringCut = substr($row['functie'], 0, 20); 

            // make sure it ends in a word so assassinate doesn't become ass... 
            $row['functie'] = substr($stringCut, 0, strrpos($stringCut, ' ')).'...'; 
        } 
        if (strlen($row['naamBedrijf']) > 25) { 

            // truncate string 
            $stringCut2 = substr($row['naamBedrijf'], 0, 14); 

            // make sure it ends in a word so assassinate doesn't become ass... 
            $row['naamBedrijf'] = substr($stringCut2, 0, strrpos($stringCut2, ' ')).'...'; 
        } 
        if (strlen($row['omschrijvingKort']) > 63) { 

            // truncate string 
            $stringCut2 = substr($row['omschrijvingKort'], 0, 63); 

            // make sure it ends in a word so assassinate doesn't become ass... 
            $row['omschrijvingKort'] = substr($stringCut2, 0, strrpos($stringCut2, ' ')).'...'; 
        } 

        return $row; 
    } 
    function generateDiv($row) 
    { 
        $date = date("d-m-Y", strtotime($row['datum'])); 
        return " 
            <div class='vacatureinfo2'> 
                <img class='userimg2' src='../../uploads/userimage/". $row['image'] ."' id='imge'/> 
                <p class='func-br-pl pull-left'>". $row['functie'] ." - ". $row['naamBedrijf'] ." - ". $row['plaats'] ."</p><p class='dtm pull-right'>". $date ."</p> 
                <div class='omschrijvingkort2'> 
                    ". $row['omschrijvingKort'] ." 
                </div> 
                <p class='pull-right'><a href='reactie?id=" . $row['vacatureID'] . "'>Reageer</a> | <a href='informatie-vacature?id=" . $row['vacatureID'] . "'>Meer informatie</a></p> 
            </div> 
            <hr> 
        "; 
    }

    // pagination
    echo $paginate; 
?>

UPDATE 2:

Maybe there when something wrong with changing the code below to PDO?

<?php
include('connect.php'); 

$tableName="vacature";      
$targetpage = "testpaging2.php";    
$limit = 10; 

$query = "SELECT COUNT(vacatureID) as num FROM $tableName";
$total_pages = mysql_fetch_array(mysql_query($query));
$total_pages = $total_pages[num];

$stages = 3;
$page = mysql_escape_string($_GET['page']);
if($page){
    $start = ($page - 1) * $limit; 
}else{
    $start = 0; 
}   

// Get page data
$query1 = "SELECT vacature.*, werkgever.image, werkgever.plaats, werkgever.provincie, werkgever.naamBedrijf FROM vacature LEFT JOIN werkgever ON (vacature.werkgeverID = werkgever.werkgeverID) ORDER BY vacature.datum DESC LIMIT $start, $limit";
$result = mysql_query($query1);

// Initial page num setup
if ($page == 0){$page = 1;}
$prev = $page - 1;  
$next = $page + 1;                          
$lastpage = ceil($total_pages/$limit);      
$LastPagem1 = $lastpage - 1;                    


$paginate = '';
if($lastpage > 1)
{   
    $paginate .= "<div class='paginate'>";
    // Previous
    if ($page > 1){
        $paginate.= "<a href='$targetpage?page=$prev'>previous</a>";
    }else{
        $paginate.= "<span class='disabled'>previous</span>";   }

    // Pages    
    if ($lastpage < 7 + ($stages * 2))  // Not enough pages to breaking it up
    {   
        for ($counter = 1; $counter <= $lastpage; $counter++)
        {
            if ($counter == $page){
                $paginate.= "<span class='current'>$counter</span>";
            }else{
                $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
        }
    }
    elseif($lastpage > 5 + ($stages * 2))   // Enough pages to hide a few?
    {
        // Beginning only hide later pages
        if($page < 1 + ($stages * 2))       
        {
            for ($counter = 1; $counter < 4 + ($stages * 2); $counter++)
            {
                if ($counter == $page){
                    $paginate.= "<span class='current'>$counter</span>";
                }else{
                    $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
            }
            $paginate.= "...";
            $paginate.= "<a href='$targetpage?page=$LastPagem1'>$LastPagem1</a>";
            $paginate.= "<a href='$targetpage?page=$lastpage'>$lastpage</a>";       
        }
        // Middle hide some front and some back
        elseif($lastpage - ($stages * 2) > $page && $page > ($stages * 2))
        {
            $paginate.= "<a href='$targetpage?page=1'>1</a>";
            $paginate.= "<a href='$targetpage?page=2'>2</a>";
            $paginate.= "...";
            for ($counter = $page - $stages; $counter <= $page + $stages; $counter++)
            {
                if ($counter == $page){
                    $paginate.= "<span class='current'>$counter</span>";
                }else{
                    $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
            }
            $paginate.= "...";
            $paginate.= "<a href='$targetpage?page=$LastPagem1'>$LastPagem1</a>";
            $paginate.= "<a href='$targetpage?page=$lastpage'>$lastpage</a>";       
        }
        // End only hide early pages
        else
        {
            $paginate.= "<a href='$targetpage?page=1'>1</a>";
            $paginate.= "<a href='$targetpage?page=2'>2</a>";
            $paginate.= "...";
            for ($counter = $lastpage - (2 + ($stages * 2)); $counter <= $lastpage; $counter++)
            {
                if ($counter == $page){
                    $paginate.= "<span class='current'>$counter</span>";
                }else{
                    $paginate.= "<a href='$targetpage?page=$counter'>$counter</a>";}                    
            }
        }
    }

            // Next
    if ($page < $counter - 1){ 
        $paginate.= "<a href='$targetpage?page=$next'>next</a>";
    }else{
        $paginate.= "<span class='disabled'>next</span>";
        }

    $paginate.= "</div>";       


}
 echo $total_pages.' Results';



    while($row = mysql_fetch_array($result))
    {

    echo "
        <div class='vacatureinfo2'> 
            <img class='userimg2' src='../../uploads/userimage/". $row['image'] ."' id='imge'/> 
            <p class='func-br-pl pull-left'>". $row['functie'] ." - ". $row['naamBedrijf'] ." - ". $row['plaats'] ."</p><p class='dtm pull-right'>". $date ."</p> 
            <div class='omschrijvingkort2'> 
                ". $row['omschrijvingKort'] ." 
            </div> 
            <p class='pull-right'><a href='reactie?id=" . $row['vacatureID'] . "'>Reageer</a> | <a href='informatie-vacature?id=" . $row['vacatureID'] . "'>Meer informatie</a></p> 
        </div> 
        <hr>";

    }
 // pagination
 echo $paginate;

Because when I run this page it works! But it is not PDO... See the code before this update to see how I changed the code to PDO please note that I also use functions in that code! If I know what I am doing wrong with changing it to PDO maybe that will fix this problem? But I do not know what I am doing wrong!!

Marjolein
  • 193
  • 1
  • 12

1 Answers1

-1

Try updating

$sql = 'SELECT vacature.*, werkgever.image, werkgever.plaats, werkgever.provincie, werkgever.naamBedrijf FROM vacature LEFT JOIN werkgever ON (vacature.werkgeverID = werkgever.werkgeverID) ORDER BY vacature.datum DESC LIMIT '. $start .', '. $limit .''; 
$results = $db->query($sql);

To 

$sql = $db->query('SELECT vacature.*, werkgever.image, werkgever.plaats, werkgever.provincie, werkgever.naamBedrijf FROM vacature LEFT JOIN werkgever ON (vacature.werkgeverID = werkgever.werkgeverID) ORDER BY vacature.datum DESC LIMIT '. $start .', '. $limit .''); 
$results = $db->fetchAll($sql);

Actually with out doing fetchAll your $result was a PDO query object

And with foreach($row = $results->fetch(PDO::FETCH_ASSOC)) you have just initialized the $row variable which you forgot to define $value over there so the syntax should have been foreach($array = $results->fetch(PDO::FETCH_ASSOC) as $row) Although I am not too sure about if we can have $array = $results->fetch(PDO::FETCH_ASSOC) in foreach or not

Arpita
  • 1,386
  • 1
  • 15
  • 35
  • Hey thanks for your answer but when I change `$results = $db->query($sql);` to `$results = $db->fetchAll($sql);`, add `$db->query` to my sql query and my foreach to `foreach($array = $results->fetch(PDO::FETCH_ASSOC) as $row)` But now I get the error: `Fatal error: Call to undefined method PDO::fetchAll() on line 24` And I also get the notice: `Notice: Undefined index: page on line 16` – Marjolein Oct 14 '15 at 09:52
  • Have you changed the query also to `$sql = $db->query('SELECT vacature.*, werkgever.image, werkgever.plaats, werkgever.provincie, werkgever.naamBedrijf FROM vacature LEFT JOIN werkgever ON (vacature.werkgeverID = werkgever.werkgeverID) ORDER BY vacature.datum DESC LIMIT '. $start .', '. $limit .''); ` – Arpita Oct 14 '15 at 10:15
  • Yes I did that as well – Marjolein Oct 14 '15 at 10:27
  • Update `$results = $db->fetchAll($sql);` to `$results = $sql->fetchAll();` – Arpita Oct 14 '15 at 10:35
  • Than I still get the errors: `Notice: Undefined index: page on line 20` and `Fatal error: Call to a member function fetchAll() on a non-object on line 28` and than I fetch `$results` 2 times and I think that is not possible but if I change my foreach back to what it was I still get the same errors – Marjolein Oct 14 '15 at 10:44
  • Regarding first error '$page = $db->quote($_GET['page'])' Check your Global array $_GET and ensure "page" exists over there and regarding the second error there is a possibility that there would be some error in your query try executing you query in phpmyadmin does it executes over there – Arpita Oct 14 '15 at 10:49
  • Page does exist: `next` and all my queries are working when I run them in phpmyadmin (see update for my code as it is now) – Marjolein Oct 14 '15 at 11:04
  • Try var_dump($_GET['page']) before `$page = mysql_escape_string($_GET['page']);` does it prints any value? Actually your warning says that it is unable to access the page variable from $_GET. More over has the error with the query solved – Arpita Oct 14 '15 at 12:17
  • if i do `var_dump($_GET['page']);` at the code by update 2 I get: `NULL` – Marjolein Oct 14 '15 at 12:32
  • That means at the time when you are executing `$page = mysql_escape_string($_GET['page']);` variable `'page'` does not exist in $_GET you can cross check this using var_dump($_GET) at the same place and it is another question if your error with the PDO query is solved please mark this answer as accepted – Arpita Oct 14 '15 at 12:54