Generic Repository Inconsistent accessibility

Question

Using code below:

public IGenericRepository<TEntity> Repository<TEntity>() where TEntity : class
    {
        if (repositories.Keys.Contains(typeof(TEntity)) == true)
        {
            return repositories[typeof(TEntity)] as IGenericRepository<TEntity>;
        }
        IGenericRepository<TEntity> repo = new GenericRepository<TEntity>(_context);
        repositories.Add(typeof(TEntity), repo);
        return repo;
    }

The Error I got,

Error 1 Inconsistent accessibility: return type 'DataModel.GenericRepository.IGenericRepository' is less accessible than method 'DataModel.UnitOfWork.UnitOfWork.Repository()' C:\Users\Anoop.k\documents\visual studio 2013\Projects\WebAPI\DataModel\UnitOfWork\UnitOfWork.cs 30 44 DataModel

I know that IGenericRepository repo is private by default. But in this sort of situation what to do? Please help me.

is IGenericRepository your interface? Why would interface be set as private? — Robert, Oct 14 '15 at 10:00

score 3 · Accepted Answer · answered Oct 14 '15 at 10:25

I think you should define your Interface as public.

Or try this:

public IGenericRepository<TEntity> Repository<TEntity>() where TEntity : class
{
        if (repositories.Keys.Contains(typeof(TEntity)) == true)
        {
            return repositories[typeof(TEntity)] as IGenericRepository<TEntity>;
        }
        GenericRepository<TEntity> repo = new GenericRepository<TEntity>(_context);
        repositories.Add(typeof(TEntity), repo);
        return repo;
}

Ah, now I see it. It might be a good idea, then, to point out where it's different. — Rik, Oct 14 '15 at 10:56

score 1 · Answer 2 · edited May 23 '17 at 12:23

1

You can't return a private type from a public method.

Change the accessibility of the IGenericRepository to public if you want other classes to be able to use it.

Generic Repository Inconsistent accessibility

2 Answers2