Why is MySQL INSERT query shooting an error? What does the error mean?

Question

I am trying to insert a MYSQL query as following:

  doSql("INSERT INTO users (userTypeID, memberUsername, memberHashPassword, memberFirstName, memberLastName, memberEmail, memberStreetNumber, memberStreetName, memberSuburb, memberPostcode, memberCountry, memberPhone, memberMobile, memberGender, memberNewsletter, memberImage) VALUES (2, $mUsername, $hashedPassword, $mFirstName, $mLastName, $mEmail, $mStreetNumber, $mStreetName, $mSuburb, $mPostcode, $mCountry, $mPhone, $mMobilePhone, $mGender, $mNewsletter, $destination_path)");

And I'm getting the following error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855, , , , , , , ,' at line 1

I have checked for any syntax error like semicolon missing but I don't understand why I'm getting this.

I mean where are these characters coming from: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855?

Here is the doSql function:

/********** Perform MYSQL Query **********/
function doSql($query) {
// 1. Connect to the database
$con = mysqli_connect('localhost', 'root', '', 'shahyan_gameon');
// 2. Test if connection occured
if(mysqli_connect_errno()) {
    die("Database connection failed " . mysqli_connect_error() . "( " . mysqli_connect_errno() . " )");
    return false;
}
// 3. Do the query
$result = mysqli_query($con, $query) or die(mysqli_error($con));
// mysqli_query runs a query against the database using two argument, the connection and the query string
//die() stops a script from being processed and outputs info.
if($result) {
    return $result;
} else {
    return false;
}
}

already answered in detail, please check http://stackoverflow.com/questions/11321491/when-to-use-single-quotes-double-quotes-and-backticks — Akhil S Kamath, Oct 18 '15 at 08:38
Possible duplicate of [MySQL syntax error with simple INSERT?](http://stackoverflow.com/questions/7855475/mysql-syntax-error-with-simple-insert) — try-catch-finally, Oct 18 '15 at 09:22

score 1 · Answer 1 · answered Oct 18 '15 at 08:31

you need to wrap strings in ' [quotes].

 doSql("INSERT INTO users (userTypeID, memberUsername, memberHashPassword, memberFirstName, memberLastName, memberEmail, memberStreetNumber, memberStreetName, memberSuburb, memberPostcode, memberCountry, memberPhone, memberMobile, memberGender, memberNewsletter, memberImage) VALUES (2, '$mUsername', '$hashedPassword', '$mFirstName', '$mLastName', '$mEmail', '$mStreetNumber', '$mStreetName', '$mSuburb', '$mPostcode', '$mCountry', '$mPhone', '$mMobilePhone', '$mGender', '$mNewsletter', '$destination_path')");

and it should work fine.

score 0 · Answer 2 · answered Oct 18 '15 at 08:34

try this

doSql("INSERT INTO users (userTypeID, memberUsername, memberHashPassword, memberFirstName, memberLastName, memberEmail, memberStreetNumber, memberStreetName, memberSuburb, memberPostcode, memberCountry, memberPhone, memberMobile, memberGender, memberNewsletter, memberImage) VALUES (2, '".$mUsername."', '".$hashedPassword."', '".$mFirstName."', '".$mLastName."', '".$mEmail."', '".$mStreetNumber."', '".$mStreetName."', '".$mSuburb."', '".$mPostcode."', '".$mCountry."', '".$mPhone."', '".$mMobilePhone."', '".$mGender."', '".$mNewsletter."', '".$destination_path."')");

score 0 · Answer 3 · answered Oct 18 '15 at 08:35

The syntax to insert values into a table using MySQL is as follows:

INSERT INTO table_name VALUES('strParameter1','strParameter2',intParameter1);

In your case, you should try:

doSql("INSERT INTO users VALUES(userTypeID, memberUsername, memberHashPassword, memberFirstName, memberLastName, memberEmail, memberStreetNumber, memberStreetName, memberSuburb, memberPostcode, memberCountry, memberPhone, memberMobile, memberGender, memberNewsletter, memberImage) VALUES (2, $mUsername, $hashedPassword, $mFirstName, $mLastName, $mEmail, $mStreetNumber, $mStreetName, $mSuburb, $mPostcode, $mCountry, $mPhone, $mMobilePhone, $mGender, $mNewsletter, $destination_path)");

Why is MySQL INSERT query shooting an error? What does the error mean?

3 Answers3