Adm Zip zipping files as directories

Question

I am trying to pack files into a zip file using Adm-Zip

var AdmZip = require('adm-zip');

var pathToZip = 'build/release/Ext.zip';


var zip = new AdmZip();

zip.addLocalFile('background.js');
zip.addLocalFile('chrome_ex_oauth.html');
zip.addLocalFolder('images');
zip.writeZip(pathToZip);

However, all the files are getting added as folders inside the zip and the actual content is not getting zipped.

The Getting Started reference is below and this seems to be a very simple example which is not working as expected. What am I doing wrong? https://github.com/cthackers/adm-zip/wiki/ADM-ZIP-Introduction

1.5 yrs later and I am having the same issue... – niczak Mar 28 '17 at 19:50 — niczak, Mar 28 '17 at 19:50

score 16 · Accepted Answer · edited Apr 14 '16 at 22:52

16

So I did some digging: https://github.com/cthackers/adm-zip/blob/master/adm-zip.js#L275

addFile is ultimately called by addLocalFile, and that seems to be where the error is occurring, specifically on line 281 where it checks if the ZipEntry is a directory. The wrong flags are getting applied.

To get around this, I ended up calling addFile manually and specified the attributes myself, so that it wouldn't rely on auto-detection and incorrectly flag files as directories.

addFile(filePathInArchive, fileBuffer, '', 0644 << 16);

To get a fileBuffer yourself, you can use fs.readFile or fs.readFileSync

edited Apr 14 '16 at 22:52

Josh

100
6

answered Mar 14 '16 at 14:24

Speedy

326
2
7

1

Most files added this way to the ZIP are corrupted. – Pawel Aug 19 '16 at 23:00
Linke to issue on Github: https://github.com/cthackers/adm-zip/issues/182 – Leon S. Nov 23 '17 at 09:11

score 2 · Answer 2 · answered Jan 18 '18 at 09:00

2

var zip = new admZip();
var fs=require('fs-extra');
zip.addFile('NGINX/app.js',fs.readFileSync('./app.js'),'',0644);
zip.writeZip("./files.zip");

answered Jan 18 '18 at 09:00

Andrew Rayan

350
1
7

score 1 · Answer 3 · answered Dec 16 '15 at 15:29

1

From the wiki of adm-zip:

[void] addLocalFile(String localPath, String zipPath)

Adds a file from the disk to the archive.

[void] addLocalFolder(String localPath, String zipPath)

Adds a local directory and all its nested files and directories to the archive

As it seems you miss the second parameter that is the zipPath.

answered Dec 16 '15 at 15:29

sstauross

2,602
2
30
50

3

no, I can confirm the OP claim. addLocalFile adds the file as a directory with or without the 2nd argument. I also note that addFile does the same unless you use 0644 << 16 as the 4th parameter. – Astra Bear Sep 10 '16 at 05:32

Adm Zip zipping files as directories

3 Answers3